Skip to content

fix: rename get_incremental_microbatch_sql to capture_microbatch_compiled_code_sql #1024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GuyEshdat merged 4 commits into from
Jun 18, 2026
+3 −3
Merged

fix: rename get_incremental_microbatch_sql to capture_microbatch_compiled_code_sql #1024

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ea17eca
fix: rename macro to capture_microbatch_compiled_code_sql to avoid br…
GuyEshdat Jun 18, 2026
6ced287
fix: update test to call elementary.capture_microbatch_compiled_code_sql
GuyEshdat Jun 18, 2026
ae0f3b1
fix: rename to capture_and_execute_microbatch_compiled_code_sql
GuyEshdat Jun 18, 2026
8d7858d
fix: update test to call capture_and_execute_microbatch_compiled_code…
GuyEshdat Jun 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion integration_tests/tests/test_dbt_artifacts/test_microbatch_compiled_code.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ def _with_microbatch_macro_file(dbt_project: DbtProject, macro_name: str):
macro_path = dbt_project.project_dir_path / "macros" / "microbatch.sql"
macro_sql = """
{% macro __MACRO_NAME__(arg_dict) %}
{{ return(elementary.get_incremental_microbatch_sql(arg_dict)) }}
{{ return(elementary.capture_and_execute_microbatch_compiled_code_sql(arg_dict)) }}
{% endmacro %}
""".replace(
"__MACRO_NAME__", macro_name
Expand Down
4 changes: 2 additions & 2 deletions macros/edr/dbt_artifacts/microbatch/capture_microbatch_compiled_code.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
incremental strategy resolution in all projects.
To apply this behavior, users should:
1) Override `get_incremental_microbatch_sql` in their own project and delegate to
`elementary.get_incremental_microbatch_sql(arg_dict)`.
`elementary.capture_and_execute_microbatch_compiled_code_sql(arg_dict)`.
2) Enable dbt behavior flag `require_batched_execution_for_custom_microbatch_strategy`.

This flow is currently not supported for adapters:
Expand All @@ -17,7 +17,7 @@

This flow is currently not supported for dbt Fusion.
-#}
{% macro get_incremental_microbatch_sql(arg_dict) %}
{% macro capture_and_execute_microbatch_compiled_code_sql(arg_dict) %}
{% if execute and model is defined %}
{% do elementary.capture_microbatch_compiled_code_for_model() %}
{% endif %}
Expand Down
Loading