fix: use per-task question when loading from history (#1366)#1678
Open
carlosjarenom wants to merge 1 commit into
Open
fix: use per-task question when loading from history (#1366)#1678carlosjarenom wants to merge 1 commit into
carlosjarenom wants to merge 1 commit into
Conversation
Previously, loading a project from history used the same single question string (project.last_prompt) for every task, regardless of what question each individual task had been created with. Now each task is replayed with its own question from task.question, falling back to the project-level question if a task's question is missing. Closes eigent-ai#1366
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When loading a project from history, every task was replayed with the same question
(
project.last_prompt), regardless of what question each individual task had beencreated with. This caused tasks to show incorrect questions when replayed.
Changes
src/store/projectStore.ts: AddedtaskQuestions?parameter toloadProjectFromHistory;each task now uses
taskQuestions[index] || questioninstead of always usingquestionsrc/lib/replay.ts: PasstaskQuestions?through toprojectStore.loadProjectFromHistorysrc/components/HistorySidebar/index.tsx: ExtracttaskQuestionsListfromproject.tasks(each task has its own
questionfield) and pass it toloadProjectFromHistoryWhy
Each
HistoryTaskalready stores its ownquestionfield. This fix ensures that fieldis actually used during history replay, falling back to the project-level question only
when a task's question is missing.
Closes #1366