chore: Fix provider configuration state#1664
Open
fengju0213 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the provider configuration flow so a successfully validated BYOK/custom provider is saved, refreshed, and marked configured correctly.
Fixes #1665
Root Cause
The frontend sent
is_valid, while the server model uses the existingis_vaildfield. The server update allowlist also omittedendpoint_url,model_type, andencrypted_config, so updates could appear successful while leaving the stored provider unchanged. New providers could also fail to become the default immediately because the frontend readprovider_idfrom stale React state.Changes
is_vaildfield, while still acceptingis_validfor compatibility.endpoint_url,model_type, andencrypted_config.is_validcompatibility input.Impact
This affects all custom/BYOK providers, including AWS Bedrock and AWS Bedrock Converse. Direct AWS Bedrock users should still use the Bedrock Converse provider; the plain Bedrock provider remains for OpenAI-compatible Bedrock gateways.
Validation
npm run type-checknpx eslint src/pages/Agents/Models.tsx --no-warn-ignored --quietuv run --extra dev pytest tests/test_provider_model.pyuv run ruff check app/model/provider/provider.py app/domains/model_provider/service/provider_service.py tests/test_provider_model.py