findNodeProcess compatible bosybox ps command#65
findNodeProcess compatible bosybox ps command#65nAnderYang wants to merge 2 commits intoeggjs:masterfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request updates the process discovery logic in src/helper.ts to handle BusyBox environments by detecting the ps implementation and adjusting flags accordingly. Feedback suggests that the BusyBox-specific command should include -w and -A flags to ensure all processes are listed and command arguments are not truncated.
busybox no parameter `-w` and `-A` Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
commit: |
|
@nAnderYang Need to fix it first at https://github.com/eggjs/egg/tree/next/tools/scripts, then sync it here |
The issue of
egg-scripts stopfailing to run on Alpine (Buxybox) systems.Summary by CodeRabbit