Skip to content

Simplify GTK3 screenshot logic #1533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ptziegler merged 1 commit into from
Jun 18, 2026
Merged

Simplify GTK3 screenshot logic #1533

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 35 additions & 1 deletion org.eclipse.wb.os.linux/src_java24/org/eclipse/wb/internal/os/linux/ScreenshotMaker.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
import org.eclipse.swt.widgets.Control;
import org.eclipse.swt.widgets.Display;
import org.eclipse.swt.widgets.Shell;
import org.eclipse.swt.widgets.Widget;

import java.lang.foreign.MemorySegment;
import java.util.HashMap;
Expand Down Expand Up @@ -148,7 +149,40 @@ private void makeShots0(final Shell shell) {
* model. Can be <code>null</code>.
* @return the GdkPixmap* or cairo_surface_t* of {@link Shell}.
*/
protected abstract Image makeShot(Shell shell, BiConsumer<GtkWidget, Image> callback);
protected Image makeShot(Shell shell, BiConsumer<GtkWidget, Image> callback) {
return traverse(shell, callback);
}

private Image traverse(Widget w, BiConsumer<GtkWidget, Image> callback) {
GtkWidget widget = GtkWidget.from(w);
Image image = getImageSurface(GtkWidget.from(w));
if (image == null) {
return null;
}
if (callback != null) {
callback.accept(widget, image);
}
if (w instanceof Composite composite) {
for (Control childWidget : composite.getChildren()) {
Image childImage = traverse(childWidget, callback);
if (childImage == null) {
continue;
}
if (callback == null) {
childImage.dispose();
}
}
}
return image;
}

/**
* Captures the given widget.
*
* @param widget The widget to capture
* @return An image containing the visual representation of the given widget.
*/
protected abstract Image getImageSurface(GtkWidget widget);

private boolean bindImage(final Control control, final Image image) {
if (control.getData(OSSupport.WBP_NEED_IMAGE) != null && control.getData(OSSupport.WBP_IMAGE) == null) {
Expand Down
35 changes: 1 addition & 34 deletions ...pse.wb.os.linux/src_java24/org/eclipse/wb/internal/os/linux/gtk3/GTK3ScreenshotMaker.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,43 +27,14 @@
import org.eclipse.swt.SWT;
import org.eclipse.swt.graphics.Device;
import org.eclipse.swt.graphics.Image;
import org.eclipse.swt.widgets.Composite;
import org.eclipse.swt.widgets.Control;
import org.eclipse.swt.widgets.Shell;
import org.eclipse.swt.widgets.Widget;

import java.util.function.BiConsumer;

/**
* Creates a screenshot of a given widget using the GTK3 API.
*/
public class GTK3ScreenshotMaker extends ScreenshotMaker {

@Override
protected Image makeShot(Shell shell, BiConsumer<GtkWidget, Image> callback) {
return traverse(shell, callback);
}

private Image traverse(Widget widget, BiConsumer<GtkWidget, Image> callback) {
Image image = getImageSurface(GtkWidget.from(widget), callback);
if (image == null) {
return null;
}
if (widget instanceof Composite composite) {
for (Control childWidget : composite.getChildren()) {
Image childImage = traverse(childWidget, callback);
if (childImage == null) {
continue;
}
if (callback == null) {
childImage.dispose();
}
}
}
return image;
}

protected Image getImageSurface(GtkWidget widget, BiConsumer<GtkWidget, Image> callback) {
protected Image getImageSurface(GtkWidget widget) {
GdkWindow window = GTK3.gtk_widget_get_window(widget);
if (!GDK3.gdk_window_is_visible(window)) {
// don't deal with unmapped windows
Expand All @@ -77,10 +48,6 @@ protected Image getImageSurface(GtkWidget widget, BiConsumer<GtkWidget, Image> c
GDK3.gdk_window_process_updates(window, true);
// take screenshot
Image image = createImage(window, width, height);
// get Java code notified
if (callback != null) {
callback.accept(widget, image);
}
// done
return image;
}
Expand Down
Loading