fix(dns): support bare IPv6 resolver addresses#6199
Open
Harshal96 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
Fixes #6194
Fixes parsing of configured DNS resolver addresses so bare IPv6 literals are accepted without being mistaken for
host:portvalues.IPv6 DNS server addresses contain
:characters, so the previouslastIndexOf(':')parsing treated bare IPv6 literals as if they included a port. That could reject valid resolver addresses or parse them incorrectly.How
host:portvalues.Testing
NameResolverTestcoverage for bare IPv6 DNS servers.