Copy followAlternativeServices in HttpClientOptions#6191
Closed
shblue21 wants to merge 1 commit into
Closed
Conversation
Member
|
actually I think that the followAlternativeServices from HttpClientOptions should be removed instead because it does not make much sense |
shblue21
force-pushed
the
fix/http-client-options-copy
branch
from
31749a6 to
e18edc4
Compare
shblue21
force-pushed
the
fix/http-client-options-copy
branch
from
e18edc4 to
ca76b0b
Compare
Contributor
Author
|
Thanks. Since #6192 removes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
The HttpClientOptions copy constructor did not copy followAlternativeServices, so copied options could lose that setting.
Conformance:
I have signed the ECA