Enforce cc_feature mutually_exclusive#29
Merged
Merged
Conversation
Member
Author
|
Already implemented. Only docs will be updated. |
There was a problem hiding this comment.
Pull request overview
This PR moves sanitizer incompatibility enforcement (ASan+TSan, LSan+TSan) into the canonical Bazel C++ feature model by adding cc_mutually_exclusive_category constraints to the sanitizer cc_feature definitions, and updates documentation to describe feature-level enforcement as the primary mechanism (with the existing genrule retained as a secondary guard).
Changes:
- Add mutually-exclusive runtime categories in
sanitizers/features/BUILD.bazeland wire them intoscore_asan,score_lsan, andscore_tsanviamutually_exclusive. - Update
sanitizers/README.mdto document feature-layer exclusivity, expected analysis-time failure mode, and the remaining role ofsanitizer_combination_check. - Update top-level
README.mdto describe the enforcement stack (feature level → genrule → compiler backstop).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| sanitizers/features/BUILD.bazel | Adds cc_mutually_exclusive_category targets and attaches them to sanitizer cc_features via mutually_exclusive. |
| sanitizers/README.md | Documents mutually-exclusive runtime categories as primary enforcement and reframes the genrule as secondary. |
| README.md | Updates public docs to describe enforcement at feature level first, then genrule, then compiler. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
nradakovic
force-pushed
the
nira_issue_28
branch
4 times, most recently
from
July 2, 2026 15:01
3a7128d to
1f49e53
Compare
antonkri
approved these changes
Jul 2, 2026
RSingh1511
requested review from
RSingh1511
and removed request for
Rahul-Sutariya
July 3, 2026 05:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #28