Skip to content

Add HealthMonitoring requirements#3089

Open
pawelrutkaq wants to merge 1 commit into
eclipse-score:mainfrom
qorix-group:pawelrutkaq_hm_req
Open

Add HealthMonitoring requirements#3089
pawelrutkaq wants to merge 1 commit into
eclipse-score:mainfrom
qorix-group:pawelrutkaq_hm_req

Conversation

@pawelrutkaq

Copy link
Copy Markdown
Contributor

@github-actions

Copy link
Copy Markdown

The created documentation from the pull request is available at: docu-html

:security: NO
:safety: ASIL_B
:derived_from: stkh_req__functional_req__file_based[version==1]
:status: invalid

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is invalid ok?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just followed how others are done, we may move it to the correct state in this PR. @aschemmel-tech ?

Comment on lines +1081 to +1082
The :term:`Health Monitor` shall support deadline supervision to allow
monitoring timely execution within application to detect timing violations.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think following version reads easier and still provide the same message:

The :term:Health Monitor shall provide deadline supervision to detect timing violations during application execution.

Comment on lines +1094 to +1095
The :term:`Health Monitor` shall support logical supervision to allow
monitoring execution flow within application to detect logical errors.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would propose this version:

The :term:Health Monitor shall provide logical supervision to detect logical errors during application execution.

It should read easier without going too much into the details.

Comment on lines +1107 to +1108
The :term:`Health Monitor` shall support checkpoint supervision to allow
monitoring periodic execution within application to detect failures.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you meant alive supervision here. I would propose to reword as follow:

The :term:Health Monitor shall provide alive supervision to detect deviations from the expected execution of application activities.

Please note that I'm not fully happy with deviations from the expected execution of application activities wording, but it follows two other proposals. Feel free to propose alternative wording that doesn't go into too much details (as this is a high level requirement).

If this proposal is accepted, then ID would need to change as well.

Comment on lines +1294 to +1295
The :term:`Health Monitor` shall provide modular configuration file support to
configure health checks.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what is meant by this requirement...

Do you mean split-able configuration? By this I mean, a single application should be able to have alive configuration in one file and deadline + logical configuration in another file?
Or do we mean that part of configuration can came from C++ code and another part from a file?
Or maybe that we should simply be able to read config from a file?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Backlog
Status: No status

Development

Successfully merging this pull request may close these issues.

Add HealthMonitor Feature requirements

3 participants