update of change management to consider new FEP proposal#748
Conversation
masc2023
requested review from
PandaeDo,
RolandJentschETAS,
aschemmel-tech and
pahmann
as code owners
|
The created documentation from the pull request is available at: docu-html |
qor-lb
left a comment
qor-lb
left a comment
There was a problem hiding this comment.
Definitely goes into the right direction, thanks! some minor changes below.
| Use the content :ref:`Decision Record Template <decision_record_template>` to create a | ||
| Change Request. |
There was a problem hiding this comment.
Not every change should/must end up in a decision record. I tried to also document this in the CMP in score. The DR/FEP path should be only for "bigger"/"major" changes - because this path also takes a lot more time to find agreement. We should still have a shorter path for smaller changes that don't need that level of alignment.
Can we somehow separate the information that has to be available in a change request from the format? That way we could then define in the CMP in score that major changes persist this information in a DR via the FEP and that smaller changes can still move forward if this information is only available in a issue without needing a prior DR?
There was a problem hiding this comment.
Currently https://github.com/eclipse-score/.github/blob/24c3501a931460f1d89123a3ea21750c414e7f22/.github/ISSUE_TEMPLATE/1a_FeatureRequest.yml defines which work products are affected by Change Request, "Scope" changes, otherwise, just fill out a normal taks, w/o Change Management, using https://github.com/eclipse-score/.github/blob/24c3501a931460f1d89123a3ea21750c414e7f22/.github/ISSUE_TEMPLATE/4_Task.yml
|
|
||
| Therefore guidelines :need:`gd_temp__change_feature_request` and | ||
|
|
||
| Therefore guideline :need:`gd_temp__change_decision_record` is available. This guideline |
There was a problem hiding this comment.
gd_temp__change_decision_record is not really a guideline
There was a problem hiding this comment.
replaced with template
| All statements here for components are also valid for *SW Modules*. | ||
|
|
||
| As a rule of thumb, a Change Request is needed, if feature or component requirements | ||
| are changed. |
There was a problem hiding this comment.
maybe better "are changed in a way that also will cause a version update"
| The Change Request implementation must be tracked until it is closed. | ||
|
|
||
| Use the content :ref:`Feature Request Template <chm_feature_templates>` or | ||
| :ref:`Component Request Template <chm_component_templates>` to document the implementation |
There was a problem hiding this comment.
better call "creation" instead "implementation" because at this point nothing is implemented (maybe a PoC).
| For a CR that adds new functionality or changes behaviour, it is helpful to include a section on how to teach users, new and experienced, how to apply the CR to their work. | ||
|
|
||
|
|
||
| Rejected Ideas |
There was a problem hiding this comment.
Seems to me covered by the DR alternatives. Also reference below to deleted "Rationale section"
| Security Impact | ||
| =============== | ||
|
|
||
| [How could a malicious user take advantage of this new/modified feature?] |
There was a problem hiding this comment.
Is this content moved somewhere or do we not need it any more? Maybe in the Impact Analysis Template?
There was a problem hiding this comment.
is part now of Impact Analysis Template
| [What is the expected ASIL level?] | ||
|
|
||
|
|
||
| License Impact |
There was a problem hiding this comment.
do we consider this somewhere?
There was a problem hiding this comment.
is part now of Impact Analysis Template
| A CR shall specify the stakeholder requirements as part of our platform/project. | ||
| Thereby the :need:`rl__project_lead` will approve these requirements as part of accepting the CR (e.g. merging the PR with the CR). | ||
|
|
||
| Backwards Compatibility |
There was a problem hiding this comment.
do we consider this somewhere?
There was a problem hiding this comment.
is part now of Impact Analysis Template
| In case safety or security is affected, in addition the impact analysis template | ||
| : :ref:`Impact Analysis Template <chm_impact_analysis_templates>` can be used to detail | ||
| out the impact on safety/security. | ||
| out the impact on safety/security. Copy the relevant parts from the impact analysis |
There was a problem hiding this comment.
it is not clear what the "relevant parts" are. And why copy it? Copy it with content or only the headlines?
There was a problem hiding this comment.
formulated in better way, copy complete content or reference to the template
3 participants
As proposed the Change Management process is updated to reflect the FEP.
Resolves partly: eclipse-score/score#3085