Using new versions of docs-as-code#189
Open
MaciejKaszynski wants to merge 1 commit into
Open
Conversation
MaciejKaszynski
requested review from
antonkri,
arsibo,
pawelrutkaq and
rmaddikery
as code owners
July 14, 2026 12:05
MaciejKaszynski
had a problem deploying
to
workflow-approval
July 14, 2026 12:05 — with
GitHub Actions
Error
MaciejKaszynski
requested a deployment
to
workflow-approval
July 14, 2026 12:05 — with
GitHub Actions
Waiting
MaciejKaszynski
requested a deployment
to
workflow-approval
July 14, 2026 12:05 — with
GitHub Actions
Waiting
MaciejKaszynski
requested a deployment
to
workflow-approval
July 14, 2026 12:05 — with
GitHub Actions
Waiting
License Check Results🚀 The license check job ran with the Bazel command: bazel run --lockfile_mode=error //:license-checkStatus: Click to expand output |
MaciejKaszynski
force-pushed
the
update-docs-as-code
branch
from
July 14, 2026 12:08
bcade19 to
4927487
Compare
MaciejKaszynski
requested a deployment
to
workflow-approval
July 14, 2026 12:08 — with
GitHub Actions
Waiting
MaciejKaszynski
requested a deployment
to
workflow-approval
July 14, 2026 12:08 — with
GitHub Actions
Waiting
MaciejKaszynski
temporarily deployed
to
workflow-approval
July 14, 2026 12:08 — with
GitHub Actions
Inactive
rmaddikery
reviewed
Jul 16, 2026
|
|
||
| bazel_dep(name = "score_docs_as_code", version = "4.6.0", dev_dependency = True) | ||
|
|
||
| bazel_dep(name = "score_docs_as_code", version = "4.6.1") |
Contributor
There was a problem hiding this comment.
Why is the dev_dependency removed? Please explain it in the commit msg or in PR description so that future devs can follo-up on the reasoning and do not blindly remove it
Contributor
Author
There was a problem hiding this comment.
I blindly applied the patches given in the linked gh issue
|
The created documentation from the pull request is available at: docu-html |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notes for Reviewer
Fixes #183
Applied the patch to remove dev_dependency from docs-as-code and platforms.
Note there are already 2 PRs:
However for docs-as-code the platform update is also needed so this merged it.
Pre-Review Checklist for the PR Author
Checklist for the PR Reviewer
Post-review Checklist for the PR Author
References
Closes #