Add pic feature to QNX cc_toolchain_config#108
Conversation
Introduce a `pic` feature that passes -fPIC for compile/assemble actions when the `pic` variable is available, and register it in the toolchain feature list.
There was a problem hiding this comment.
Pull request overview
Adds the missing pic feature to the QNX cc_toolchain_config template so Bazel’s PIC builds (e.g., shared libraries producing .pic.o) actually compile/assemble with -fPIC when the pic build variable is present. This aligns the QNX template with the existing Linux template behavior and addresses issue #107.
Changes:
- Introduce a
picfeature that injects-fPICfor compile and assemble-related actions gated byexpand_if_available = "pic". - Register the new
picfeature in the toolchain’s feature list alongsidesupports_pic.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
AI-assisted review (Claude): Severity: Critical: 0, Important: 0, Suggestions: 0 The change is a faithful port of the Linux template's Coverage looks fine: LGTM. |
Introduce a
picfeature that passes -fPIC for compile/assemble actions when thepicvariable is available, and register it in the toolchain feature list.resolves #107