Conversation
rozyczko
added
[scope] enhancement
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces an initial implementation steps for adding Bayesian MCMC (DREAM) sampling and analysis to EasyReflectometryLib, with a focus on a clean user-facing API and modular architecture.
The most important changes are:
Design and Implementation Plan
BAYESIAN_IN_ERL.md, a detailed implementation plan outlining the separation of classical optimization and Bayesian sampling APIs, the introduction of asample()method for MCMC, new analysis modules, dependency requirements, and the testing strategy.Analysis Module Creation
src/easyreflectometry/analysis/__init__.pyto expose Bayesian analysis utilities, includingPosteriorResults, plotting, summary, credible interval, and posterior predictive functions, making them available for import throughout the library.Public API Enhancement
src/easyreflectometry/__init__.pyto exportPosteriorResultsin the library’s public API, ensuring that users can directly access Bayesian analysis results and utilities.