Skip to content

Fix the reference error in Parameter#51

Open
seventil wants to merge 2 commits intodevelopfrom
fix_parameter_width
Open

Fix the reference error in Parameter#51
seventil wants to merge 2 commits intodevelopfrom
fix_parameter_width

Conversation

@seventil
Copy link
Copy Markdown
Contributor

@seventil seventil commented May 5, 2026

Instantiating EaElements.Parameter component as is results in a reference error:
EasyApp/src/EasyApplication/Gui/Elements/Parameter.qml:22:5: ReferenceError: parameterFieldWidth is not defined

This PR removes width definition from EaElements.Parameter, which results in a fallback on TextField's ImplicitWidth.

@seventil seventil added [scope] bug Bug report or fix (major.minor.PATCH) [priority] lowest Very low urgency labels May 5, 2026
@seventil seventil self-assigned this May 5, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (develop@c55d01c). Learn more about missing BASE report.

Additional details and impacted files
@@            Coverage Diff            @@
##             develop     #51   +/-   ##
=========================================
  Coverage           ?   0.00%           
=========================================
  Files              ?       4           
  Lines              ?     387           
  Branches           ?       0           
=========================================
  Hits               ?       0           
  Misses             ?     387           
  Partials           ?       0           
Flag Coverage Δ
integration 0.00% <ø> (?)
unittests 0.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@seventil
Copy link
Copy Markdown
Contributor Author

seventil commented May 5, 2026

Also noticed an issue with padding in units. Here how regular text and degrees look currently
no_top_padding
no_top_padding_regular

and here how they look with proposed topPadding added:
top_padding_025
top_padding_025_regular

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[priority] lowest Very low urgency [scope] bug Bug report or fix (major.minor.PATCH)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant