fix(ci): route deploy-benchmark through the shared ci-setup action#48
Merged
Conversation
Same pnpm/action-setup version mismatch as #42, in a second place: this workflow had its own inline pnpm+node+install steps, duplicating (and drifting from) ci-setup's, with a hardcoded pnpm version that never got that fix. Routing it through ./.github/actions/ci-setup instead of duplicating those steps means there's now exactly one place a future pnpm bump needs to touch.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
deploy-benchmark.ymlfailed on every push tomainwithERR_PNPM_BAD_PM_VERSION("Multiple versions of pnpm specified") — the exact bug fixed in #42, but in a second place #42 never touched: this workflow had its own inlinepnpm/action-setup@v4+actions/setup-node@v4+ install steps, duplicating (and drifting from) the sharedci-setupcomposite action, still pinned toversion: 10.20.0againstpackageManager: pnpm@11.10.0.Fix: route this workflow through
./.github/actions/ci-setup, the same composite actionci-checks.ymlandrelease.ymlalready use, instead of duplicating pnpm/node/install setup inline. There's now exactly one place a future pnpm bump needs to touch — this can't drift out of sync again.Test plan
pnpm install+pnpm -C benchmark/demo build— succeeds locally