fix(ci): unblock the changesets release PR#46
Merged
Conversation
Two checks were failing on every release PR by design, not by accident: - versioning ran `changeset status` against the release PR itself, which fails because that PR consumes changesets rather than adding one. Skip the job for the changeset-release/main branch. - format ran oxfmt against changesets' own auto-generated CHANGELOG.md entries, which never match its style since nothing hand-formats them. Added a .prettierignore excluding CHANGELOG.md (oxfmt reads it by default with no config wiring needed).
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The "chore(release): version packages" PR (#45) has been permanently
BLOCKED— not from a token/permissions issue, but from two CI checks that fail on every release PR by design:versioningrunspnpm changeset status --since=origin/mainagainst the release PR itself. That check fails because the release PR's whole job is to consume the pending changesets (bump versions, update CHANGELOG.md, delete the.mdfiles) — so it always looks like "packages changed, no changeset" from the check's point of view. Skipped this job specifically on thechangeset-release/mainbranch.formatrunsoxfmt --checkagainst theCHANGELOG.mdfiles changesets itself generates, which never matchoxfmt's style since nothing hand-formats them. Added a.prettierignoreexcluding**/CHANGELOG.md—oxfmtreads.prettierignoreautomatically, no other config changes needed.Test plan
pnpm format:check— clean (182 files matched vs 190 before; the 8CHANGELOG.mdfiles are now excluded)pnpm test— 307/307 passingpnpm lint/pnpm typecheck— clean