Update PHP - Drupal core - Minor and patch to ~11.4.0#2757
Update PHP - Drupal core - Minor and patch to ~11.4.0#2757AlexSkrypnyk wants to merge 13 commits into
Conversation
| datasource | package | from | to | | ---------- | ----------------------------- | ------- | ------ | | packagist | drupal/core-composer-scaffold | 11.3.13 | 11.4.0 | | packagist | drupal/core-recommended | 11.3.13 | 11.4.0 |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughThe PR updates Drupal core Composer constraints, adds a Drupal page recipe with its related configuration, and runs that recipe during non-production provisioning. ChangesComposer, page recipe, and provisioning
Estimated code review effort: 3 (Moderate) | ~25 minutes Possibly related issues
Possibly related PRs
Suggested labels: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
📖 Documentation preview for this pull request has been deployed to Netlify: https://6a46137d9b4f56cbc27868e9--vortex-docs.netlify.app This preview is rebuilt on every commit and is not the production documentation site. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2757 +/- ##
==========================================
- Coverage 86.70% 86.25% -0.46%
==========================================
Files 96 89 -7
Lines 4723 4568 -155
Branches 47 3 -44
==========================================
- Hits 4095 3940 -155
Misses 628 628 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@scripts/provision-10-example.sh`:
- Around line 39-44: The recipe path in the content model setup relies on the
current working directory instead of the script location. Update the
`./vendor/bin/dr recipe` call in the provisioning script to resolve
`recipes/page` relative to the script using its own directory (as done by
`vortex-provision-sanitize-db` via `BASH_SOURCE[0]`), so
`provision-10-example.sh` works regardless of where it is invoked from.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 5c3924cb-247d-4297-bda5-dc55e4caf7bd
⛔ Files ignored due to path filters (1)
.vortex/installer/tests/Fixtures/handler_process/_baseline/scripts/provision-10-example.shis excluded by!.vortex/installer/tests/Fixtures/**
📒 Files selected for processing (1)
scripts/provision-10-example.sh
| # The demo site modules attach behaviour to the 'page' content type, so it | ||
| # must exist before those modules are installed and their deploy hooks run. | ||
| task "Creating the content model." | ||
| ./vendor/bin/dr recipe "$(pwd)/recipes/page" --no-interaction | ||
| pass "Created the content model." | ||
|
|
There was a problem hiding this comment.
🩺 Stability & Availability | 🟠 Major | ⚡ Quick win
Recipe path relies on pwd, not script location.
"$(pwd)/recipes/page" assumes the script is invoked with the repo root as the current working directory. The provisioning runner in .vortex/tooling/src/vortex-provision invokes custom scripts via "${file}" from the loop over provision-*.sh, and sibling scripts in that runner resolve paths relative to the script itself, e.g. "$(dirname "${BASH_SOURCE[0]}")/vortex-provision-sanitize-db", rather than pwd. If this script is ever invoked from a different working directory, the recipe path will resolve incorrectly and the content-model step will fail before later provisioning/module-deploy-hook steps run.
🔧 Suggested fix: resolve path relative to script location
- ./vendor/bin/dr recipe "$(pwd)/recipes/page" --no-interaction
+ ./vendor/bin/dr recipe "$(dirname "${BASH_SOURCE[0]}")/../recipes/page" --no-interactionAdjust the relative path to match the actual directory layout of this script relative to recipes/page.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| # The demo site modules attach behaviour to the 'page' content type, so it | |
| # must exist before those modules are installed and their deploy hooks run. | |
| task "Creating the content model." | |
| ./vendor/bin/dr recipe "$(pwd)/recipes/page" --no-interaction | |
| pass "Created the content model." | |
| # The demo site modules attach behaviour to the 'page' content type, so it | |
| # must exist before those modules are installed and their deploy hooks run. | |
| task "Creating the content model." | |
| ./vendor/bin/dr recipe "$(dirname "${BASH_SOURCE[0]}")/../recipes/page" --no-interaction | |
| pass "Created the content model." |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@scripts/provision-10-example.sh` around lines 39 - 44, The recipe path in the
content model setup relies on the current working directory instead of the
script location. Update the `./vendor/bin/dr recipe` call in the provisioning
script to resolve `recipes/page` relative to the script using its own directory
(as done by `vortex-provision-sanitize-db` via `BASH_SOURCE[0]`), so
`provision-10-example.sh` works regardless of where it is invoked from.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Code coverage (threshold: 90%) Per-class coverage |
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
|
Code coverage (threshold: 90%) Per-class coverage |
This PR contains the following updates:
~11.3.13→~11.4.0~11.3.13→~11.4.0Release Notes
drupal/core-composer-scaffold (drupal/core-composer-scaffold)
v11.4.0Compare Source
drupal/core-recommended (drupal/core-recommended)
v11.4.0Compare Source
Configuration
📅 Schedule: (in timezone UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR has been generated by Mend Renovate.
Summary by CodeRabbit
recipespath is included in builds (including therecipes/pageoverride), while broader recipe ignores remain in place.