Skip to content

Update PHP - Drupal core - Minor and patch to ~11.4.0#2757

Open
AlexSkrypnyk wants to merge 13 commits into
mainfrom
deps/php-drupal-core-minor-patch
Open

Update PHP - Drupal core - Minor and patch to ~11.4.0#2757
AlexSkrypnyk wants to merge 13 commits into
mainfrom
deps/php-drupal-core-minor-patch

Conversation

@AlexSkrypnyk

@AlexSkrypnyk AlexSkrypnyk commented Jul 2, 2026

Copy link
Copy Markdown
Member

This PR contains the following updates:

Package Change Age Confidence
drupal/core-composer-scaffold (source) ~11.3.13~11.4.0 age confidence
drupal/core-recommended ~11.3.13~11.4.0 age confidence

Release Notes

drupal/core-composer-scaffold (drupal/core-composer-scaffold)

v11.4.0

Compare Source

drupal/core-recommended (drupal/core-recommended)

v11.4.0

Compare Source


Configuration

📅 Schedule: (in timezone UTC)

  • Branch creation
    • "before 2am"
  • Automerge
    • At any time (no schedule defined)

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate.

Summary by CodeRabbit

  • New Features
    • Added a starter “Basic page” content type, including the body field and default + teaser view and form display configuration.
    • Improved non-production provisioning to automatically create the page content model during setup.
  • Chores
    • Updated Composer constraints for newer Drupal 11 releases and expanded the plugin allowlist to include Symfony runtime.
    • Adjusted ignore rules so the recipes path is included in builds (including the recipes/page override), while broader recipe ignores remain in place.

| datasource | package                       | from    | to     |
| ---------- | ----------------------------- | ------- | ------ |
| packagist  | drupal/core-composer-scaffold | 11.3.13 | 11.4.0 |
| packagist  | drupal/core-recommended       | 11.3.13 | 11.4.0 |
@AlexSkrypnyk AlexSkrypnyk added the Dependencies Pull request was raised automatically by a dependency bot label Jul 2, 2026
@github-project-automation github-project-automation Bot moved this to BACKLOG in Vortex 1.x Jul 2, 2026
@coderabbitai

coderabbitai Bot commented Jul 2, 2026

Copy link
Copy Markdown

Review Change Stack

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

Walkthrough

The PR updates Drupal core Composer constraints, adds a Drupal page recipe with its related configuration, and runs that recipe during non-production provisioning.

Changes

Composer, page recipe, and provisioning

Layer / File(s) Summary
Update Drupal core constraints
composer.json
Bumps drupal/core-composer-scaffold and drupal/core-recommended to ~11.4.0 and adds symfony/runtime to config.allow-plugins.
Add page recipe config
.gitignore, recipes/page/recipe.yml, recipes/page/config/...
Allows the page recipe path in git, and adds the page recipe metadata, content type, body field storage and instance, and default form/view displays for the page bundle.
Run page recipe during provisioning
scripts/provision-10-example.sh, .dockerignore
Adds a non-production pre-step that runs the recipes/page Drupal recipe before later setup steps, and includes recipes in the Docker build context.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Possibly related issues

Possibly related PRs

Suggested labels: Needs review

Poem

I dug a cozy page recipe nook,
Then hopped through config like a book.
Core got a small nudge,
Provisioning took a trudge,
And now the rabbit does a happy look. 🐇

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: upgrading Drupal core dependencies to ~11.4.0.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch deps/php-drupal-core-minor-patch

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown

📖 Documentation preview for this pull request has been deployed to Netlify:

https://6a46137d9b4f56cbc27868e9--vortex-docs.netlify.app

This preview is rebuilt on every commit and is not the production documentation site.

@github-actions

This comment has been minimized.

@AlexSkrypnyk

This comment has been minimized.

2 similar comments
@AlexSkrypnyk

This comment has been minimized.

@AlexSkrypnyk

This comment has been minimized.

@codecov

codecov Bot commented Jul 2, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 86.25%. Comparing base (8718f34) to head (7763f2f).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
scripts/provision-10-example.sh 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2757      +/-   ##
==========================================
- Coverage   86.70%   86.25%   -0.46%     
==========================================
  Files          96       89       -7     
  Lines        4723     4568     -155     
  Branches       47        3      -44     
==========================================
- Hits         4095     3940     -155     
  Misses        628      628              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@scripts/provision-10-example.sh`:
- Around line 39-44: The recipe path in the content model setup relies on the
current working directory instead of the script location. Update the
`./vendor/bin/dr recipe` call in the provisioning script to resolve
`recipes/page` relative to the script using its own directory (as done by
`vortex-provision-sanitize-db` via `BASH_SOURCE[0]`), so
`provision-10-example.sh` works regardless of where it is invoked from.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 5c3924cb-247d-4297-bda5-dc55e4caf7bd

📥 Commits

Reviewing files that changed from the base of the PR and between 4195812 and 6bd7b6d.

⛔ Files ignored due to path filters (1)
  • .vortex/installer/tests/Fixtures/handler_process/_baseline/scripts/provision-10-example.sh is excluded by !.vortex/installer/tests/Fixtures/**
📒 Files selected for processing (1)
  • scripts/provision-10-example.sh

Comment on lines +39 to +44
# The demo site modules attach behaviour to the 'page' content type, so it
# must exist before those modules are installed and their deploy hooks run.
task "Creating the content model."
./vendor/bin/dr recipe "$(pwd)/recipes/page" --no-interaction
pass "Created the content model."

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🩺 Stability & Availability | 🟠 Major | ⚡ Quick win

Recipe path relies on pwd, not script location.

"$(pwd)/recipes/page" assumes the script is invoked with the repo root as the current working directory. The provisioning runner in .vortex/tooling/src/vortex-provision invokes custom scripts via "${file}" from the loop over provision-*.sh, and sibling scripts in that runner resolve paths relative to the script itself, e.g. "$(dirname "${BASH_SOURCE[0]}")/vortex-provision-sanitize-db", rather than pwd. If this script is ever invoked from a different working directory, the recipe path will resolve incorrectly and the content-model step will fail before later provisioning/module-deploy-hook steps run.

🔧 Suggested fix: resolve path relative to script location
-  ./vendor/bin/dr recipe "$(pwd)/recipes/page" --no-interaction
+  ./vendor/bin/dr recipe "$(dirname "${BASH_SOURCE[0]}")/../recipes/page" --no-interaction

Adjust the relative path to match the actual directory layout of this script relative to recipes/page.

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
# The demo site modules attach behaviour to the 'page' content type, so it
# must exist before those modules are installed and their deploy hooks run.
task "Creating the content model."
./vendor/bin/dr recipe "$(pwd)/recipes/page" --no-interaction
pass "Created the content model."
# The demo site modules attach behaviour to the 'page' content type, so it
# must exist before those modules are installed and their deploy hooks run.
task "Creating the content model."
./vendor/bin/dr recipe "$(dirname "${BASH_SOURCE[0]}")/../recipes/page" --no-interaction
pass "Created the content model."
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@scripts/provision-10-example.sh` around lines 39 - 44, The recipe path in the
content model setup relies on the current working directory instead of the
script location. Update the `./vendor/bin/dr recipe` call in the provisioning
script to resolve `recipes/page` relative to the script using its own directory
(as done by `vortex-provision-sanitize-db` via `BASH_SOURCE[0]`), so
`provision-10-example.sh` works regardless of where it is invoked from.

@github-actions

This comment has been minimized.

@AlexSkrypnyk

This comment has been minimized.

2 similar comments
@AlexSkrypnyk

This comment has been minimized.

@AlexSkrypnyk

This comment has been minimized.

@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown

Code coverage (threshold: 90%)

  Classes: 100.00% (1/1)
  Methods: 100.00% (2/2)
  Lines:   98.55% (204/207)
Per-class coverage
Drupal\ys_demo\Plugin\Block\CounterBlock
  Methods: 100.00% ( 2/ 2)   Lines: 100.00% ( 10/ 10)

@AlexSkrypnyk

This comment has been minimized.

2 similar comments
@AlexSkrypnyk

This comment has been minimized.

@AlexSkrypnyk

Copy link
Copy Markdown
Member Author

Code coverage (threshold: 90%)

  Classes: 100.00% (1/1)
  Methods: 100.00% (2/2)
  Lines:   98.55% (204/207)
Per-class coverage
Drupal\ys_demo\Plugin\Block\CounterBlock
  Methods: 100.00% ( 2/ 2)   Lines: 100.00% ( 10/ 10)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dependencies Pull request was raised automatically by a dependency bot

Projects

Status: BACKLOG

Development

Successfully merging this pull request may close these issues.

1 participant