Skip to content

fix: honor blue-specific llm model configuration#354

Closed
l50 wants to merge 2 commits into
dreadnode:mainfrom
l50:fix-blue-worker-llm-model-fallback
Closed

fix: honor blue-specific llm model configuration#354
l50 wants to merge 2 commits into
dreadnode:mainfrom
l50:fix-blue-worker-llm-model-fallback

Conversation

@l50
Copy link
Copy Markdown
Contributor

@l50 l50 commented May 27, 2026

Summary

  • Blue workers now prefer ARES_BLUE_LLM_MODEL, then fall back to ARES_LLM_MODEL, mirroring the orchestrator's blue-only mode.
  • Removed the hardcoded anthropic/claude-sonnet-4-20250514 default that caused blue workers to ask for ANTHROPIC_API_KEY when the var was unset.
  • Worker errors explicitly when neither var is configured instead of silently falling back to a Claude model.

Test plan

  • cargo check -p ares-cli --features blue
  • Deploy to K8s and run a blue-team operation; confirm workers pick up ARES_BLUE_LLM_MODEL and no longer request ANTHROPIC_API_KEY

l50 added 2 commits May 27, 2026 09:07
**Changed:**

- Blue worker model selection now prefers `ARES_BLUE_LLM_MODEL`, falls back to `ARES_LLM_MODEL`, ignores empty values, and errors clearly when no LLM model is configured instead of using a hardcoded default.
@l50
Copy link
Copy Markdown
Contributor Author

l50 commented May 27, 2026

Moving this to my fork — tracking in l50#28 instead.

@l50 l50 closed this May 27, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.03%. Comparing base (f774ba1) to head (0c42609).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #354   +/-   ##
=======================================
  Coverage   80.03%   80.03%           
=======================================
  Files         433      433           
  Lines      125577   125577           
=======================================
  Hits       100500   100500           
  Misses      25077    25077           

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@l50 l50 deleted the fix-blue-worker-llm-model-fallback branch May 27, 2026 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant