fix: honor blue-specific llm model configuration#354
Closed
l50 wants to merge 2 commits into
Closed
Conversation
**Changed:** - Blue worker model selection now prefers `ARES_BLUE_LLM_MODEL`, falls back to `ARES_LLM_MODEL`, ignores empty values, and errors clearly when no LLM model is configured instead of using a hardcoded default.
Contributor
Author
|
Moving this to my fork — tracking in l50#28 instead. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #354 +/- ##
=======================================
Coverage 80.03% 80.03%
=======================================
Files 433 433
Lines 125577 125577
=======================================
Hits 100500 100500
Misses 25077 25077 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ARES_BLUE_LLM_MODEL, then fall back toARES_LLM_MODEL, mirroring the orchestrator's blue-only mode.anthropic/claude-sonnet-4-20250514default that caused blue workers to ask forANTHROPIC_API_KEYwhen the var was unset.Test plan
cargo check -p ares-cli --features blueARES_BLUE_LLM_MODELand no longer requestANTHROPIC_API_KEY