Better error when workload set version uses package version format#54929
Draft
Copilot wants to merge 3 commits into
Draft
Better error when workload set version uses package version format#54929Copilot wants to merge 3 commits into
Copilot wants to merge 3 commits into
Conversation
Co-authored-by: marcpopMSFT <12663534+marcpopMSFT@users.noreply.github.com>
…ment Co-authored-by: marcpopMSFT <12663534+marcpopMSFT@users.noreply.github.com>
Copilot
AI
changed the title
Detect wrong workload set version format with helpful error message
Better error when workload set version uses package version format
Jun 22, 2026
Copilot created this pull request from a session on behalf of
marcpopMSFT
June 22, 2026 21:13
View session
Member
|
@copilot Fix the build errors |
…convert xUnit tests to MSTest Co-authored-by: marcpopMSFT <12663534+marcpopMSFT@users.noreply.github.com>
Contributor
Author
Fixed in the latest commit:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Users occasionally specify a workload set version in the internal NuGet package format (e.g.
10.105.0,11.100.0-preview.5.26309.3) instead of the user-facing format (10.0.105,11.0.100-preview.5). Previously this produced a confusing NuGet "package not found" failure; now it produces a clear error with the corrected version.The user-facing format always has
0as the minor component — a non-zero minor is the diagnostic signal.Changes
WorkloadSetVersion.cs— addsIsWorkloadSetVersionInPackageVersionFormat(string, out string?)which detects the wrong format and computes the corrected version string (8.203.1→8.0.203.1,11.100.0-preview.5.26309.3→11.0.100-preview.5.26309.3)WorkloadSetVersion.Validation.cs— deleted; was an orphaned file with conflicting duplicate definitions not compiled into any projectInstallingWorkloadCommand.cs— validates both--versioncommand-line values andworkloadVersionfromglobal.json, throwing early with a helpful messageWorkloadSearchVersionsCommandDefinition.cs— extends the existing version argument validator to emit the specific error instead of a generic "unrecognized argument"CliCommandStrings.resx/CommandDefinitionStrings.resx— two new error strings; all XLF files regeneratedError messages