Skip to content

Code review skill#54924

Open
mthalman wants to merge 5 commits into
dotnet:mainfrom
mthalman:dev/mthalman/code-review-skill
Open

Code review skill#54924
mthalman wants to merge 5 commits into
dotnet:mainfrom
mthalman:dev/mthalman/code-review-skill

Conversation

@mthalman

Copy link
Copy Markdown
Member

No description provided.

Copilot AI review requested due to automatic review settings June 22, 2026 20:17

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new .github/skills/code-review agent skill document intended to guide problem-focused pull request reviews in dotnet/sdk.

Changes:

  • Introduces a code-review skill with step-by-step workflow (local checkout, context gathering, review, and posting).
  • Adds guidance on change categorization, test/impact analysis, and what to flag vs. avoid flagging.

Comment thread .github/skills/code-review/SKILL.md Outdated
Comment thread .github/skills/code-review/SKILL.md Outdated
@marcpopMSFT marcpopMSFT requested a review from lbussell June 22, 2026 20:44
Comment thread .github/skills/code-review/SKILL.md Outdated
Comment thread .github/skills/code-review/SKILL.md
mthalman and others added 3 commits June 23, 2026 10:51
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Comment thread .github/skills/code-review/SKILL.md Outdated
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

@nagilson

Copy link
Copy Markdown
Member

Thanks for investing in this code review skill. Some fundamental questions:

  1. Does this get picked up by the Copilot review from GitHub? If not, is there a way to do that?

  2. Do you happen to have any demo PR reviews showing the results before and after this skill was introduced? I'm curious how it overall changes the behavior of the PR review. I think there's a lot of useful guidance here though I also tend to find the agents have gotten better over time at doing code review. There's a lot of language to parse here and I've noticed even subtle tweaks can significantly influence the outcome.

I wonder also what influenced the decisions here as many repos are adding their own code review skills such as https://github.com/microsoft/aspire-skills/blob/main/.github/skills/pr-review/SKILL.md.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants