Skip to content

JIT: Remove InlineCandidateInfo::exactContextNeedsRuntimeLookup#129898

Open
jakobbotsch wants to merge 1 commit into
dotnet:mainfrom
jakobbotsch:clean-up-inline-marking
Open

JIT: Remove InlineCandidateInfo::exactContextNeedsRuntimeLookup#129898
jakobbotsch wants to merge 1 commit into
dotnet:mainfrom
jakobbotsch:clean-up-inline-marking

Conversation

@jakobbotsch

Copy link
Copy Markdown
Member

This is unused as of recent refactorings

Copilot AI review requested due to automatic review settings June 26, 2026 16:48
@github-actions github-actions Bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jun 26, 2026
@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the InlineCandidateInfo::exactContextNeedsRuntimeLookup field and the corresponding impMarkInlineCandidate / impMarkInlineCandidateHelper parameter, simplifying the JIT inlining candidate plumbing now that the flag is no longer consumed.

Changes:

  • Drop InlineCandidateInfo::exactContextNeedsRuntimeLookup from the inline candidate info struct.
  • Remove the exactContextNeedsRuntimeLookup parameter from impMarkInlineCandidate and impMarkInlineCandidateHelper.
  • Update all call sites to the new impMarkInlineCandidate signature.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/coreclr/jit/inline.h Removes the unused InlineCandidateInfo field.
src/coreclr/jit/importercalls.cpp Updates impMarkInlineCandidate* signatures/calls and stops storing the removed flag.
src/coreclr/jit/fginline.cpp Updates the late-devirtualization inlining-mark call to the new signature.
src/coreclr/jit/compiler.h Updates declarations for the revised impMarkInlineCandidate* signatures.
src/coreclr/jit/async.cpp Updates async helper callsites to the new impMarkInlineCandidate signature.
Comments suppressed due to low confidence (1)

src/coreclr/jit/importercalls.cpp:10212

  • This comment references exactContextNeedsRuntimeLookup, but that field/parameter was removed in this PR, so the note is now stale and misleading.
        // Note exactContextNeedsRuntimeLookup is reset later on,
        // over in impMarkInlineCandidate.
        //

@jakobbotsch

Copy link
Copy Markdown
Member Author

PTAL @dotnet/jit-contrib

@jakobbotsch jakobbotsch requested a review from a team June 27, 2026 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants