JIT: Remove InlineCandidateInfo::exactContextNeedsRuntimeLookup#129898
Open
jakobbotsch wants to merge 1 commit into
Open
JIT: Remove InlineCandidateInfo::exactContextNeedsRuntimeLookup#129898jakobbotsch wants to merge 1 commit into
jakobbotsch wants to merge 1 commit into
Conversation
This is unused as of recent refactorings
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the InlineCandidateInfo::exactContextNeedsRuntimeLookup field and the corresponding impMarkInlineCandidate / impMarkInlineCandidateHelper parameter, simplifying the JIT inlining candidate plumbing now that the flag is no longer consumed.
Changes:
- Drop
InlineCandidateInfo::exactContextNeedsRuntimeLookupfrom the inline candidate info struct. - Remove the
exactContextNeedsRuntimeLookupparameter fromimpMarkInlineCandidateandimpMarkInlineCandidateHelper. - Update all call sites to the new
impMarkInlineCandidatesignature.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/coreclr/jit/inline.h | Removes the unused InlineCandidateInfo field. |
| src/coreclr/jit/importercalls.cpp | Updates impMarkInlineCandidate* signatures/calls and stops storing the removed flag. |
| src/coreclr/jit/fginline.cpp | Updates the late-devirtualization inlining-mark call to the new signature. |
| src/coreclr/jit/compiler.h | Updates declarations for the revised impMarkInlineCandidate* signatures. |
| src/coreclr/jit/async.cpp | Updates async helper callsites to the new impMarkInlineCandidate signature. |
Comments suppressed due to low confidence (1)
src/coreclr/jit/importercalls.cpp:10212
- This comment references
exactContextNeedsRuntimeLookup, but that field/parameter was removed in this PR, so the note is now stale and misleading.
// Note exactContextNeedsRuntimeLookup is reset later on,
// over in impMarkInlineCandidate.
//
Member
Author
|
PTAL @dotnet/jit-contrib |
AndyAyersMS
approved these changes
Jun 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is unused as of recent refactorings