Support multi-connect on non-dual-mode IPv6#129892
Open
am11 wants to merge 4 commits into
Open
Conversation
dotnet-policy-service
Bot
added
the
community-contribution
Contributor
|
Tagging subscribers to this area: @karelz, @dotnet/ncl |
Member
Author
|
cc @rzikm, I tested it on OpenBSD box, it fixed the HttpRequestException mentioned above. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On operating systems like OpenBSD and WASI where IPv6 dual-mode isn't supported, a single socket can't reach both address families, so we re-create the still-unconnected handle for the current address' family to let the connect proceed. Since WASI doesn't use this handler, the gap never surfaced until OpenBSD end-to-end testing with TLS endpoints (
dotnet restorefailed withHttpRequestException hr=0x80004005; workaroundDOTNET_SYSTEM_NET_DISABLEIPV6=1 dotnet restoredid the trick and led to this fix)