[LoongArch64] Apply fixes for coreclr-interp on linux-loongarch64.#129887
Open
LuckyXu-HF wants to merge 1 commit into
Open
[LoongArch64] Apply fixes for coreclr-interp on linux-loongarch64.#129887LuckyXu-HF wants to merge 1 commit into
LuckyXu-HF wants to merge 1 commit into
Conversation
…like issue#127860.
Contributor
|
Tagging subscribers to this area: @agocke |
Contributor
Author
|
LA64 also hit the same issue like #127860 : Fixed: InterpreterTester.sh PASS |
LuckyXu-HF
commented
Jun 26, 2026
| // Note that the regNum == 0 only occurs under interpreter. | ||
| assert(regNum == 3 || 22 == regNum || 0 == regNum); | ||
| #elif defined(TARGET_RISCV64) | ||
| assert(regNum == 2 || 8 == regNum); |
Contributor
Author
There was a problem hiding this comment.
Hi @am11 , does riscv64 also need to modify here? I'm curious why riscv64 can pass the assertion here.
Member
There was a problem hiding this comment.
@LuckyXu-HF, tests were passing in May #127919 (comment) so I'm not sure why it wasn't failing if you think it's needed there. Are you running the same test command (with Debug configuration), I can test with latest main branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Align PR#127919 to fix the InterpreterTester.sh failed like issue:#127860 on LA64.