[devops] Move comment identifier to beginning of GitHub CI comments#25785
[devops] Move comment identifier to beginning of GitHub CI comments#25785rolfbjarne wants to merge 1 commit into
Conversation
The "[comment]: <> (...)" identifier string used to detect and hide older comments of the same type was added at the end of GitHub comments. When a comment was too large and got truncated by GitHub, the identifier would be cut off, preventing future detection and hiding of that comment. Move the identifier to the beginning of the comment so it is never truncated away. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ [CI Build #2aef1b0] Build passed (Detect API changes) ✅Pipeline on Agent |
✅ [CI Build #2aef1b0] Build passed (Build packages) ✅Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
✅ [CI Build #2aef1b0] Build passed (Build macOS tests) ✅Pipeline on Agent |
🔥 [CI Build #2aef1b0] Test results 🔥Test results❌ Tests failed on VSTS: test results 0 tests crashed, 16 tests failed, 191 tests passed. Failures❌ linker tests (tvOS)15 tests failed, 0 tests passed.Failed tests
Html Report (VSDrops) Download ❌ monotouch tests (iOS)1 tests failed, 19 tests passed.Failed tests
Html Report (VSDrops) Download Successes✅ assembly-processing: All 1 tests passed. Html Report (VSDrops) Download macOS tests✅ Tests on macOS Monterey (12): All 5 tests passed. Html Report (VSDrops) Download Linux Build VerificationPipeline on Agent |
2 participants
The
[comment]: <> (...)identifier string is used to detect and hide older GitHub comments of the same type during CI. This string was added at the end of each comment, which means that when a comment was too large for GitHub and got truncated, the identifier was cut off. This prevented the comment from being detected and hidden in the future.Move the identifier to the beginning of the comment so it is never lost to truncation.
Changes:
GitHub.psm1: AddedWriteCommentIdentifier()method, called at the top of all threeNewComment*methods. Removed identifier fromWriteCommentFooter.TestResults.psm1: Moved the[comment]: <>line from end to beginning in both code paths ofWriteComment().TestResults.Tests.ps1: Updated all 5 affected test expectations.🤖 Pull request created by Copilot