[tests] Revert workarounds for dotnet/runtime#123503. Fixes #24558. by rolfbjarne · Pull Request #25711 · dotnet/macios

rolfbjarne · 2026-06-17T12:48:19Z

Remove workarounds that were added due to dotnet/runtime#123503:

Remove EnableTrimAnalyzer=false, EnableAotAnalyzer=false, and NoWarn AD0001 from Directory.Build.props.
Remove [Ignore] attribute from BuildMyNativeAotAppWithTrimAnalysisWarning test.

🤖 Pull request created by Copilot

The workarounds (disabling trim/AOT analyzers and suppressing AD0001 warnings) are no longer necessary now that the underlying runtime issue has been fixed. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Removes temporary build/test workarounds that were introduced due to dotnet/runtime#123503, restoring normal analyzer behavior and re-enabling a previously ignored NativeAOT+trim-analysis unit test (fixing #24558).

Changes:

Remove repo-wide MSBuild properties that disabled trim/AOT analyzers and suppressed AD0001 in Directory.Build.props.
Re-enable BuildMyNativeAotAppWithTrimAnalysisWarning by removing its [Ignore] attribute.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
`Directory.Build.props`	Removes the temporary analyzer-disabling/suppression PropertyGroup added as a workaround for dotnet/runtime#123503.
`tests/dotnet/UnitTests/ProjectTest.cs`	Re-enables the NativeAOT trim-analysis warning test by dropping the issue-linked ignore.

vs-mobiletools-engineering-service2 · 2026-06-22T14:16:38Z

✅ [PR Build #75bb66f] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 75bb66ff91eaa9d0bc81ba2f0291119ca0c4c2f6 [PR build]

vs-mobiletools-engineering-service2 · 2026-06-22T14:24:12Z

✅ [PR Build #75bb66f] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 75bb66ff91eaa9d0bc81ba2f0291119ca0c4c2f6 [PR build]

vs-mobiletools-engineering-service2 · 2026-06-22T14:28:06Z

✅ API diff for current PR / commit

NET (empty diffs)

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

✅ API diff vs stable

NET (empty diffs)

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 75bb66ff91eaa9d0bc81ba2f0291119ca0c4c2f6 [PR build]

vs-mobiletools-engineering-service2 · 2026-06-22T14:37:41Z

✅ [PR Build #75bb66f] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 75bb66ff91eaa9d0bc81ba2f0291119ca0c4c2f6 [PR build]

vs-mobiletools-engineering-service2 · 2026-06-24T08:59:21Z

🚀 [CI Build #75bb66f] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 205 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 9 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ linker (iOS): All 11 tests passed. Html Report (VSDrops) Download
✅ linker (MacCatalyst): All 11 tests passed. Html Report (VSDrops) Download
✅ linker (macOS): All 11 tests passed. Html Report (VSDrops) Download
✅ linker (tvOS): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 26 tests passed. [attempt 3] Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 30 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 23 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 26 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ sharpie: All 1 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

macOS tests

✅ Tests on macOS Sonoma (14): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Sequoia (15): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Tahoe (26): All 5 tests passed. [attempt 3] Html Report (VSDrops) Download

Linux Build Verification

✅ Linux build succeeded

Pipeline on Agent
Hash: 75bb66ff91eaa9d0bc81ba2f0291119ca0c4c2f6 [PR build]

Revert workarounds for dotnet/runtime#123503. Fixes #24558.

b9ce637

The workarounds (disabling trim/AOT analyzers and suppressing AD0001 warnings) are no longer necessary now that the underlying runtime issue has been fixed. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

rolfbjarne added the copilot label Jun 17, 2026

rolfbjarne changed the base branch from main to net11.0 June 17, 2026 12:48

This comment has been minimized.

Sign in to view

Merge branch 'net11.0' into dev/rolf/revert-runtime-123503-workarounds

75bb66f

This comment has been minimized.

Sign in to view

rolfbjarne marked this pull request as ready for review June 22, 2026 14:01

Copilot AI review requested due to automatic review settings June 22, 2026 14:01

rolfbjarne enabled auto-merge (squash) June 22, 2026 14:01

Copilot started reviewing on behalf of rolfbjarne June 22, 2026 14:01 View session

Copilot AI reviewed Jun 22, 2026

View reviewed changes

This comment has been minimized.

Sign in to view

dalexsoto approved these changes Jun 22, 2026

View reviewed changes

This comment has been minimized.

Sign in to view

rolfbjarne merged commit c8eef5e into net11.0 Jun 24, 2026
56 checks passed

rolfbjarne deleted the dev/rolf/revert-runtime-123503-workarounds branch June 24, 2026 08:59

Uh oh!

Conversation

rolfbjarne commented Jun 17, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

vs-mobiletools-engineering-service2 commented Jun 22, 2026

✅ [PR Build #75bb66f] Build passed (Detect API changes) ✅

Uh oh!

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Jun 22, 2026

✅ [PR Build #75bb66f] Build passed (Build packages) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Jun 22, 2026

✅ API diff for current PR / commit

✅ API diff vs stable

ℹ️ Generator diff

Uh oh!

vs-mobiletools-engineering-service2 commented Jun 22, 2026

✅ [PR Build #75bb66f] Build passed (Build macOS tests) ✅

Uh oh!

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Jun 24, 2026

🚀 [CI Build #75bb66f] Test results 🚀

Test results

Tests counts

macOS tests

Linux Build Verification

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants