Skip to content

Make primitive collection element type a creation-time concern #38484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Make primitive collection element type a creation-time concern #38484

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
51f85b0
Make element type a creation-time concern; remove SetElementType APIs…
Copilot Jun 23, 2026
bcba01f
Address review feedback: simplify PrimitiveCollection element-type re…
Copilot Jun 23, 2026
a46cfe6
Relocate element-type setter to InternalTypeBaseBuilder; fix doc comment
Copilot Jun 23, 2026
5f5e4c2
Move ElementType instantiation into Property; inline CanSetElementTyp…
Copilot Jun 24, 2026
88f0619
Reconcile stale convention element type at model finalization
Copilot Jun 24, 2026
9f21571
Fold element-type reconciliation into ElementTypeChangedConvention; r…
Copilot Jun 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 11 additions & 15 deletions src/EFCore.Relational/EFCore.Relational.baseline.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10205,6 +10205,9 @@
{
"Member": "RelationalAnnotationProvider(Microsoft.EntityFrameworkCore.Metadata.RelationalAnnotationProviderDependencies dependencies);"
},
{
"Member": "virtual Microsoft.EntityFrameworkCore.Metadata.RelationalJsonIndex CreateJsonIndex(Microsoft.EntityFrameworkCore.Metadata.IIndex modelIndex, Microsoft.EntityFrameworkCore.Metadata.ITableIndex tableIndex);"
},
{
"Member": "static Microsoft.EntityFrameworkCore.Metadata.IRelationalJsonElement FindJsonElement(Microsoft.EntityFrameworkCore.Metadata.IPropertyBase property, Microsoft.EntityFrameworkCore.Metadata.ITable table);"
},
Expand Down Expand Up @@ -10264,9 +10267,6 @@
},
{
"Member": "virtual System.Collections.Generic.IEnumerable<Microsoft.EntityFrameworkCore.Infrastructure.IAnnotation> For(Microsoft.EntityFrameworkCore.Metadata.ITrigger trigger, bool designTime);"
},
{
"Member": "virtual Microsoft.EntityFrameworkCore.Metadata.RelationalJsonIndex CreateJsonIndex(Microsoft.EntityFrameworkCore.Metadata.IIndex modelIndex, Microsoft.EntityFrameworkCore.Metadata.ITableIndex tableIndex);"
}
],
"Properties": [
Expand Down Expand Up @@ -13742,7 +13742,7 @@
"Member": "override bool IsCandidateNavigationProperty(System.Reflection.MemberInfo memberInfo, Microsoft.EntityFrameworkCore.Metadata.IConventionModel model, bool useAttributes, out System.Type? elementType, out bool? shouldBeOwned, out bool explicitlyConfigured);"
},
{
"Member": "override bool IsCandidatePrimitiveProperty(System.Reflection.MemberInfo memberInfo, Microsoft.EntityFrameworkCore.Metadata.IConventionModel model, bool useAttributes, out Microsoft.EntityFrameworkCore.Storage.CoreTypeMapping? typeMapping, out bool explicitlyConfigured);"
"Member": "override bool IsCandidatePrimitiveProperty(System.Reflection.MemberInfo memberInfo, Microsoft.EntityFrameworkCore.Metadata.IConventionModel model, bool useAttributes, out Microsoft.EntityFrameworkCore.Storage.CoreTypeMapping? typeMapping, out System.Type? elementType, out bool explicitlyConfigured);"
}
]
},
Expand Down Expand Up @@ -14569,20 +14569,16 @@
"Member": "static Microsoft.EntityFrameworkCore.Metadata.Builders.OwnedNavigationBuilder<TSource, TTarget> HasJsonPropertyName<TSource, TTarget>(this Microsoft.EntityFrameworkCore.Metadata.Builders.OwnedNavigationBuilder<TSource, TTarget> navigationBuilder, string? name);"
},
{
"Member": "static Microsoft.EntityFrameworkCore.Metadata.Builders.OwnedNavigationBuilder ToJson(this Microsoft.EntityFrameworkCore.Metadata.Builders.OwnedNavigationBuilder builder);",
"Stage": "Obsolete"
"Member": "static Microsoft.EntityFrameworkCore.Metadata.Builders.OwnedNavigationBuilder ToJson(this Microsoft.EntityFrameworkCore.Metadata.Builders.OwnedNavigationBuilder builder);"
},
{
"Member": "static Microsoft.EntityFrameworkCore.Metadata.Builders.OwnedNavigationBuilder<TOwnerEntity, TDependentEntity> ToJson<TOwnerEntity, TDependentEntity>(this Microsoft.EntityFrameworkCore.Metadata.Builders.OwnedNavigationBuilder<TOwnerEntity, TDependentEntity> builder);",
"Stage": "Obsolete"
"Member": "static Microsoft.EntityFrameworkCore.Metadata.Builders.OwnedNavigationBuilder<TOwnerEntity, TDependentEntity> ToJson<TOwnerEntity, TDependentEntity>(this Microsoft.EntityFrameworkCore.Metadata.Builders.OwnedNavigationBuilder<TOwnerEntity, TDependentEntity> builder);"
},
{
"Member": "static Microsoft.EntityFrameworkCore.Metadata.Builders.OwnedNavigationBuilder<TOwnerEntity, TDependentEntity> ToJson<TOwnerEntity, TDependentEntity>(this Microsoft.EntityFrameworkCore.Metadata.Builders.OwnedNavigationBuilder<TOwnerEntity, TDependentEntity> builder, string? jsonColumnName);",
"Stage": "Obsolete"
"Member": "static Microsoft.EntityFrameworkCore.Metadata.Builders.OwnedNavigationBuilder<TOwnerEntity, TDependentEntity> ToJson<TOwnerEntity, TDependentEntity>(this Microsoft.EntityFrameworkCore.Metadata.Builders.OwnedNavigationBuilder<TOwnerEntity, TDependentEntity> builder, string? jsonColumnName);"
},
{
"Member": "static Microsoft.EntityFrameworkCore.Metadata.Builders.OwnedNavigationBuilder ToJson(this Microsoft.EntityFrameworkCore.Metadata.Builders.OwnedNavigationBuilder builder, string? jsonColumnName);",
"Stage": "Obsolete"
"Member": "static Microsoft.EntityFrameworkCore.Metadata.Builders.OwnedNavigationBuilder ToJson(this Microsoft.EntityFrameworkCore.Metadata.Builders.OwnedNavigationBuilder builder, string? jsonColumnName);"
}
]
},
Expand Down Expand Up @@ -17610,9 +17606,6 @@
{
"Member": "virtual void ConfigureParameter(System.Data.Common.DbParameter parameter);"
},
{
"Member": "virtual object? GetDefaultProviderValue();"
},
{
"Member": "virtual System.Data.Common.DbParameter CreateParameter(System.Data.Common.DbCommand command, string name, object? value, bool? nullable = null, System.Data.ParameterDirection direction = System.Data.ParameterDirection.Input);"
},
Expand All @@ -17634,6 +17627,9 @@
{
"Member": "static System.Reflection.MethodInfo GetDataReaderMethod(System.Type type);"
},
{
"Member": "virtual object? GetDefaultProviderValue();"
},
{
"Member": "virtual string ProcessStoreType(Microsoft.EntityFrameworkCore.Storage.RelationalTypeMapping.RelationalTypeMappingParameters parameters, string storeType, string storeTypeNameBase);"
},
Expand Down
4 changes: 3 additions & 1 deletion src/EFCore.Relational/Metadata/RelationalMemberClassifier.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,9 +62,10 @@ public override bool IsCandidatePrimitiveProperty(
IConventionModel model,
bool useAttributes,
out CoreTypeMapping? typeMapping,
out Type? elementType,
out bool explicitlyConfigured)
{
if (base.IsCandidatePrimitiveProperty(memberInfo, model, useAttributes, out typeMapping, out explicitlyConfigured))
if (base.IsCandidatePrimitiveProperty(memberInfo, model, useAttributes, out typeMapping, out elementType, out explicitlyConfigured))
{
return true;
}
Expand All @@ -77,6 +78,7 @@ public override bool IsCandidatePrimitiveProperty(
&& HasExplicitColumnType(memberInfo))
{
typeMapping = null;
elementType = null;
explicitlyConfigured = true;
return true;
}
Expand Down
Loading
Loading