Unskip tests that aren't failing anymore#38474
Open
AndriySvyryd wants to merge 12 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR re-enables a set of previously skipped tests across providers (SqlServer/Sqlite/Specification/InMemory/Cosmos), generally by removing Skip = ... markers and, in a few cases, by changing provider overrides to assert the current expected failure mode instead of skipping.
Changes:
- Unskips multiple
[Fact]/[Theory]tests by removingSkip = ...across several test suites. - Removes InMemory-specific “skip overrides” so the base GroupBy coverage runs again.
- Updates some provider overrides to assert failures (via
Assert.ThrowsAny*<XunitException>) rather than skipping, and converts one spec test from sync to async.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 18 comments.
Show a summary per file
| File | Description |
|---|---|
| test/EFCore.SqlServer.FunctionalTests/CustomConvertersSqlServerTest.cs | Unskips a SqlQuery theory for converted types. |
| test/EFCore.Sqlite.FunctionalTests/Query/Translations/Operators/BitwiseOperatorTranslationsSqliteTest.cs | Unskips xor-related overrides so the provider-specific “translation fails” assertions run. |
| test/EFCore.Specification.Tests/Query/NorthwindJoinQueryTestBase.cs | Unskips join closure-caching regression tests. |
| test/EFCore.Specification.Tests/Query/ComplexTypeQueryTestBase.cs | Unskips a complex-type projection regression test. |
| test/EFCore.Specification.Tests/CustomConvertersTestBase.cs | Converts a spec test to async and uses ToListAsync(). |
| test/EFCore.InMemory.FunctionalTests/Query/QueryBugsInMemoryTest.cs | Unskips Issue19425 regression test. |
| test/EFCore.InMemory.FunctionalTests/Query/NorthwindGroupByQueryInMemoryTest.cs | Removes skipped overrides so base GroupBy tests run again for InMemory. |
| test/EFCore.InMemory.FunctionalTests/OptimisticConcurrencyInMemoryTest.cs | Replaces skips with assertions that base optimistic concurrency tests currently fail for InMemory. |
| test/EFCore.InMemory.FunctionalTests/KeysWithConvertersInMemoryTest.cs | Replaces skips with assertions that key converters are unsupported (currently fail) for InMemory. |
| test/EFCore.InMemory.FunctionalTests/GraphUpdates/ProxyGraphUpdatesInMemoryTest.cs | Replaces skips with assertions that base proxy graph update tests fail for InMemory. |
| test/EFCore.Cosmos.FunctionalTests/CustomConvertersCosmosTest.cs | Replaces skip with assertion that a specific converter test currently fails for Cosmos. |
AndriySvyryd
commented
Jun 20, 2026
AndriySvyryd
commented
Jun 23, 2026
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Removed the Optional_one_to_one_are_orphaned method from ProxyGraphUpdatesInMemoryTest.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
AndriySvyryd
commented
Jun 24, 2026
…lValidator blank line Co-authored-by: AndriySvyryd <6539701+AndriySvyryd@users.noreply.github.com>
AndriySvyryd
commented
Jun 24, 2026
…tarting_detached and Required_one_to_one_with_alternate_key_are_cascade_deleted_starting_detached Co-authored-by: AndriySvyryd <6539701+AndriySvyryd@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.