[TrimmableTypeMap] Reflection-free TrimmableTypeMapType/ValueManager#11801
Draft
simonrozsival wants to merge 4 commits into
Draft
[TrimmableTypeMap] Reflection-free TrimmableTypeMapType/ValueManager#11801simonrozsival wants to merge 4 commits into
simonrozsival wants to merge 4 commits into
Conversation
Adds TrimmableTypeMapValueManager + reflection-free TrimmableTypeMapTypeManager and wires opt-in selection (RuntimeFeature.TrimmableTypeMap) in JNIEnvInit. Builds on the CoreCLR JavaMarshal split. Default stays managed; depends on array-codegen (#11753) and other slices to be fully functional at runtime. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
simonrozsival
added
copilot
Revert Color.cs/JavaProxyThrowable.cs formatting, RuntimeFeature feature-gates (suppressions cover it), and the ITypeMap array-proxy rename (deferred to array PR). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the reflection-free
TrimmableTypeMapValueManagerandTrimmableTypeMapTypeManager, plus the opt-in wiring inJNIEnvInit(RuntimeFeature.TrimmableTypeMap). NativeAOT default staysmanaged; trimmable is opt-in.This is stacked on #11799 (CoreCLR JavaMarshal split + Java.Interop bump) and deliberately excludes the array-codegen generator work (#11753) — Mono.Android still compiles, but trimmable apps won't be fully functional at runtime until the generator slices land.
Blocked on (prerequisites)
CI is not expected green until these merge. Marked draft.
Mono.Android builds with 0 errors.