[WIP] Test v5 nuget-msi-convert (WiX 6 migration)#11743
Draft
jonathanpeppers wants to merge 2 commits into
Draft
[WIP] Test v5 nuget-msi-convert (WiX 6 migration)#11743jonathanpeppers wants to merge 2 commits into
jonathanpeppers wants to merge 2 commits into
Conversation
Smoke-test the WiX 3 -> WiX 6.0.3-dotnet.4 migration of the nuget-msi-convert template in Xamarin.yaml-templates (PR #752740, branch jonathanpeppers-nuget-msi-convert-v5). Adds a temporary second repository resource `yaml-templates-v5` pinned to the feature branch, and switches the nuget-msi-convert template reference from `v4.yml@yaml-templates` to `v5.yml@yaml-templates-v5`. All other templates (sign-artifacts, policheck, build-summary) continue to consume yaml-templates@main, so this is a single-template swap. Not to be merged: revert once the Xamarin.yaml-templates v5 PR lands. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Instead of cloning the yaml-templates resource into a second entry, point the existing one at the v5 feature branch. The other templates (sign-artifacts/v4.yml, security/policheck/v3.yml, build-summary/v1.yml) are present on the feature branch too, so this is safe for the smoke test. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not merge
Smoke-test for the WiX 3 → WiX 6.0.3-dotnet.4 migration of the
nuget-msi-converttemplate inDevDiv/Xamarin.yaml-templates(internal ADO PR #752740, feature branchjonathanpeppers-nuget-msi-convert-v5).The goal is to validate the new
v5.ymltemplate against a real Xamarin.Android signed build (signType: Test) before the v5 PR merges intoXamarin.yaml-templates@main.Changes
yaml-templates-v5pinned torefs/heads/jonathanpeppers-nuget-msi-convert-v5.nuget-msi-convert/job/v4.yml@yaml-templatestonuget-msi-convert/job/v5.yml@yaml-templates-v5.yamlResourceNameparameter accordingly.sourceRepositoriesToScan.excludelist.v4.ymltov5.yml.All other consumers of
yaml-templates@main(sign-artifacts, policheck, build-summary) are unchanged — this is a single-template swap.What changed in v5 vs v4 (for reviewer context)
6.0.3-dotnet.4(was WiX 3)swixBuildPackageVersion: 1.1.922(was 1.1.392)arcadePackageVersion: 11.0.0-beta.26325.102(was 9.0.0-beta.24509.3)arcadeTasksFxVersion: net(wasnetcoreapp3.1)dotNetSdkVersion: 10.0.x(was 9.0.x — required, arcade 11.x tasks are net10.0)convert.projnow built withDotNetCoreCLI@2 / dotnet msbuild(Core MSBuild) instead ofMSBuild@1desktop msbuild, because arcade 11.x workload tasks ship onlytools/net/(.NETCoreApp v10). SwixBuild still uses desktop msbuild via the internal_FindMSBuildtarget.All new parameters have sensible defaults in
v5.yml, so dotnet/android does not need to override any of them.Revert plan
Revert this PR (or the equivalent diff) once Xamarin.yaml-templates PR #752740 merges to
main— at that point the standardyaml-templates@mainresource will pick upv5.ymland the second repository entry can be removed.cc @jonpryor — please queue an internal signed build against this branch with
signType: Testto validate end-to-end.