[main] Update dependencies from dotnet/dotnet#11219
Open
dotnet-maestro[bot] wants to merge 3 commits intomainfrom
Open
[main] Update dependencies from dotnet/dotnet#11219dotnet-maestro[bot] wants to merge 3 commits intomainfrom
dotnet-maestro[bot] wants to merge 3 commits intomainfrom
Conversation
…426.11 On relative base path root Microsoft.DotNet.Build.Tasks.Feed From Version 11.0.0-beta.26215.121 -> To Version 11.0.0-beta.26226.111 Microsoft.DotNet.Cecil From Version 0.11.5-preview.26215.121 -> To Version 0.11.5-preview.26226.111 Microsoft.NET.ILLink , Microsoft.NETCore.App.Ref From Version 11.0.0-preview.4.26215.121 -> To Version 11.0.0-preview.5.26226.111 Microsoft.NET.Sdk , Microsoft.TemplateEngine.Authoring.Tasks From Version 11.0.100-preview.4.26215.121 -> To Version 11.0.100-preview.5.26226.111
dotnet-maestro
Bot
requested review from
jonathanpeppers and
simonrozsival
as code owners
dotnet/runtime#125673 added a Condition to _PrepareTrimConfiguration that skips adding the app assembly as TrimmerRootAssembly when OutputType=Library. Since Android apps set OutputType=Library (no managed Main()), the app assembly is no longer rooted by the upstream SDK, causing ILLink to omit it from linked output. This breaks NativeAOT (ILC cannot find the linked app DLL) and trimmed MonoVM builds. Fix by explicitly adding the app assembly as TrimmerRootAssembly with RootMode=All in _FixRootAssembly, instead of relying on converting the upstream EntryPoint root. Also remove the now-unnecessary _RemoveAppAssemblyFromTrimmerRoots workaround in Trimmable.CoreCLR.targets, since the upstream fix it was waiting for (dotnet/runtime#125673) has landed. Fixes #11146 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the following dependencies
From https://github.com/dotnet/dotnet