[NFC] Remove @devhigley/parse-proxy as a dependency#385
Open
pnappa wants to merge 1 commit intodocusign:masterfrom
Open
[NFC] Remove @devhigley/parse-proxy as a dependency#385pnappa wants to merge 1 commit intodocusign:masterfrom
pnappa wants to merge 1 commit intodocusign:masterfrom
Conversation
This is a random package written by someone, which serves as a risk for supply chain integrity. There is no trusted publishing established for this package, so there's a high risk that it could be taken over & cause an attack against all your consumers. The package isn't very well written, and has some bad handling for cases which are likely to be brought up. The behaviour can be fully implemented using builtins. For example, `localhost:8000` throws, which is a fairly common path to handling proxies, whilst IPv6 support is also non-existent (e.g. http://[::1]:8080 throws).
Author
|
As an aside, literally the only public dependencies of this package are other docusign packages, so I assume it's prudent to go and remove them from the other packages too? Ideally the signature for the docusign client would accept proxy options similar to what axios accepts, but this would be a breaking change, so I decided on keeping the string based proxy definition. |
Author
|
Another important note is that there's a few other dependencies which could be taken out:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a random package written by someone, which serves as a risk for supply chain integrity. There is no trusted publishing established for this package, so there's a high risk that it could be taken over & cause an attack against all your consumers.
The package isn't very well written, and has some bad handling for cases which are likely to be brought up. The behaviour can be fully implemented using builtins.
For example,
localhost:8000throws, which is a fairly common path to handling proxies, whilst IPv6 support is also non-existent (e.g. http://[::1]:8080 throws).