Conversation
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
…ts in their respective home directories
…ce it contained two topics; moved domain management into provision since sso has its own instructions in setup
|
/review |
|
❌ PR Review Failed — The review agent encountered an error and could not complete the review. View logs. |
|
/review |
![docker-agent[bot]](https://avatars.githubusercontent.com/in/2787757?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
/review |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
/review |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Use Hugo source paths with .md or _index.md for cross-references from admin overview, organization pages, and company users. Align SSO, SCIM, roles, enforce sign-in, Settings Management, domains, billing paths, and related targets with content/manuals layout. Made-with: Cursor
Point billing FAQs, payment method, 3D Secure, and tax certificate cross-links to Hugo source paths under content/manuals/billing and subscription. Made-with: Cursor
Point Create a Docker ID to content/manuals/accounts/create-account.md. Made-with: Cursor
Use /manuals/admin/company/_index.md for Hugo ref resolution. Made-with: Cursor
Use /manuals/... and /reference/api/hub/latest.md paths for Hugo ref resolution on JIT, provision-scim, and migrate-scim. Made-with: Cursor
Use /manuals/ paths for security announcements, access tokens, JIT, FAQs, and troubleshoot; /reference/api/hub/latest.md for Hub API; repair security-announcements URL typo and Markdown link punctuation in troubleshoot-sso. Made-with: Cursor
Point domain and SSO connect anchors to /manuals/...; align CLI reference links with /reference/cli/...md forms used elsewhere in manuals. Made-with: Cursor
|
/review |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Point SCIM section links at scim/_index.md instead of nonexistent scim.md. Route supported-attributes anchor to provision-scim.md. Fix group mapping link in admin user management guide to use /manuals/... path. Made-with: Cursor
|
/review |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
/review |
There was a problem hiding this comment.
Assessment: 🔴 CRITICAL
PR: SCIM jit edits — SCIM/SSO/provisioning docs reorganization (44 files)
| Severity | Finding | File |
|---|---|---|
| 🔴 HIGH | SSO requires: version stripped to bare string |
data/summary.yaml:265 |
| 🟡 MEDIUM | Old redirect alias /security/troubleshoot/troubleshoot-provisioning/ dropped |
troubleshoot-provisioning.md:9 |
| 🟡 MEDIUM | Inconsistent 'Roles and permissions' link targets (line 36 vs line 109) | admin/company/users.md:36 |
3 findings in changed code. The HIGH finding affects user-facing version requirement display on all SSO documentation pages.
| subscription: [Business] | ||
| for: Administrators | ||
| requires: Docker Desktop [4.42](/manuals/desktop/release-notes.md#4420) and later | ||
| requires: Docker Desktop |
There was a problem hiding this comment.
[HIGH] SSO requires: field stripped of version number
The requires: entry for SSO was changed from:
requires: Docker Desktop [4.42](/manuals/desktop/release-notes.md#4420) and later
to:
requires: Docker Desktop
This drives the {{< summary-bar >}} shortcode on SSO documentation pages. Other entries in summary.yaml that have no minimum version requirement omit the requires: field entirely — they don't use a bare requires: Docker Desktop string. The bare string is anomalous and will render an incomplete/misleading version badge for users. If the 4.42 requirement is still valid, this is a regression. If SSO no longer requires a minimum Desktop version, the field should be removed entirely rather than left as a bare product name.
There was a problem hiding this comment.
@aevesdocker I'll follow your lead here. I dropped it in summary.yaml per your feedback, but looks like the bot is getting fussy about it
akristen
requested review from
aevesdocker
and removed request for
craig-osterhout
2 participants
just a lot of stuff that got out of hand idk. it started out as a nice reorg of provision and turned into a nightmare of my own making