Skip to content

gha: Add milestone validation workflow#6941

Merged
vvoland merged 1 commit intodocker:masterfrom
vvoland:milestone-validate
Apr 20, 2026
Merged

gha: Add milestone validation workflow#6941
vvoland merged 1 commit intodocker:masterfrom
vvoland:milestone-validate

Conversation

@vvoland
Copy link
Copy Markdown
Collaborator

@vvoland vvoland commented Apr 20, 2026

Ensure PRs have a milestone set and that it matches the next release version declared in the root VERSION file.

@vvoland vvoland added this to the 29.4.1 milestone Apr 20, 2026
@vvoland vvoland self-assigned this Apr 20, 2026
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@vvoland vvoland requested a review from thaJeztah April 20, 2026 11:26
Comment thread VERSION
@@ -1 +1 @@
29.4.0-dev
29.4.1
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make it ignore the -dev suffix? I think we intentionally added the -dev so that building a binary won't show up as 29.4.1 (tagged version).

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm how about the reverse? See now

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That probably works for now (we need to remember bumping the version 😅)

Ensure PRs have a milestone set and that it matches the next release
version declared in the root VERSION file.

Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
@vvoland vvoland force-pushed the milestone-validate branch from 055e5f6 to efbbc0c Compare April 20, 2026 12:51
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vvoland vvoland merged commit 4e25e5c into docker:master Apr 20, 2026
96 of 97 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants