Drop --with-pear with PHP 8.6#1654
Conversation
| \ | ||
| {{ if install_pear_pecl then ( -}} | ||
| # --enable-mbstring is included here because otherwise there's no way to get pecl to use it properly (see https://github.com/docker-library/php/issues/195) | ||
| --enable-mbstring \ |
There was a problem hiding this comment.
The major justification to compile in mbstring was to support pecl installed packages that depend on it. Our line is to only include extensions that must be compiled into php itself versus what can be added after while following upstream recommendations. So, I agree with this change to drop mbstring in 8.6+.
If they still need it, users can add docker-php-ext-install mbstring in PHP 8.6 and above.
| # https://github.com/docker-library/php/issues/888 | ||
| "linux-headers", | ||
| # oniguruma is part of mbstring in php 7.4+ | ||
| "oniguruma-dev" |
There was a problem hiding this comment.
This can be dropped here (and for debian below) without pear + mbstring (found this missing in my own setup when forcefully re-adding mbstring for forward compatibility)
There was a problem hiding this comment.
Good point, also in context of this RFC: https://wiki.php.net/rfc/eol-oniguruma
3 participants
Even if we don't adopt PIE in the upstream PHP image (because #1554 (comment) “just works”), we should stop shipping the PECL binary with PHP 8.6.
see #1554