fix(e2e): wait for campaign to appear after creation#54
Merged
Conversation
create_campaign_first_catalog navigates back to the campaigns list, but on slower environments (prod) the list query can still be in flight when callers immediately read campaign names. Wait for the new campaign heading to be visible before returning so subsequent list queries are reliable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CampaignPage.create_campaign_first_catalog navigates back to the campaigns list after creation, but on slower environments (prod) the list query can still be in flight when callers immediately read campaign names. This causes test_campaign_reports_download_buttons to fail with "Need at least one campaign".
Wait for the new campaign heading to be visible before returning so subsequent list queries are reliable.