fix(deploy): gate and replace deleteSellerProfile resolver migration#53
Merged
Merged
Conversation
The migration step was using the wrong target address and therefore did nothing. It also relied on an in-place pipeline-resolver update, which the AWS provider does not reliably order before function deletion. - Add a state-based gate so the migration only runs while old pipeline functions still exist in the Terraform state. - Use -replace on the module-prefixed resolver address to force recreation, which removes old function references before the full apply destroys the old functions. This makes the migration self-cleaning and ensures it only runs once.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The migration step in the production deploy workflow was using the wrong target address and relied on an in-place resolver update that the AWS provider does not reliably order before function deletion.
This change:
-replacewith the correct module-prefixed resolver address to force recreation.