Add Makefile verify gate and post-merge Definition of Done for agents#13
Merged
Conversation
- make verify mirrors the CI pipeline (fmt-check, vet, build, lint, race tests) and is the mandatory pre-push step in AGENTS.md. - AGENTS.md: a task is not done until post-merge CI on main is green; tests must be hermetic (explicit env for external tools like git). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
dosubot
Bot
added
the
size:M
There was a problem hiding this comment.
Pull request overview
Adds a local make verify gate intended to mirror CI checks, and updates AGENTS.md to formalize hermetic testing expectations plus a post-merge “Definition of Done” (main CI must be green after merge).
Changes:
- Introduces a new
Makefilewith build/test/fmt/lint/vet targets and averifymeta-target. - Updates
AGENTS.mdto require runningmake verifybefore push and to require post-merge CI verification onmain. - Documents hermetic test requirements (explicit environment for external tools like
git).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| Makefile | Adds standard Go developer/CI gate targets plus a verify entry point. |
| AGENTS.md | Updates contribution workflow + DoD to require local verification, hermetic tests, and post-merge main CI checks. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -0,0 +1,29 @@ | |||
| GOFLAGS ?= | |||
Comment on lines
+28
to
+29
| # Full pre-push gate: mirrors the CI pipeline. Run before every push. | ||
| verify: fmt-check vet build lint test |
Comment on lines
+21
to
+22
| - Run `make verify` (fmt-check + vet + build + lint + `go test -race`). | ||
| This mirrors the CI pipeline and is mandatory before every push. |
Mirrors AGENTS.md for Claude Code agents working in this repo: a task is done only when post-merge CI on main is green; tests must pass on a bare Linux runner (clean-HOME repro command included). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #12 (which fixes the red CI on main caused by a non-hermetic test).
make verifymirrors the CI pipeline (fmt-check, vet, build, lint,go test -race) — single pre-push entry point for humans and coding agents.mainis green after merge (gh run list --branch main --workflow CI --limit 1).This is the process half of the incident fix: PR #10 merged green-at-PR-time but broke main, and nobody circled back for two months.
🤖 Generated with Claude Code