Remove redundant MGF1 implementation + allow MGF injection#288
Open
stesie wants to merge 4 commits intodigitalbazaar:mainfrom
Open
Remove redundant MGF1 implementation + allow MGF injection#288stesie wants to merge 4 commits intodigitalbazaar:mainfrom
stesie wants to merge 4 commits intodigitalbazaar:mainfrom
Conversation
This way the test output makes clear why each test is passed twice (with different message digests).
Removes the redundant MGF1 implementation in PKCS#1 module, prefering injection of standalone MGF instance instead. Old call schemes are still supported and transparently create MGF1 instances as needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PKCS#1 module currently has its own
rsa_mgf1implementation, even so we have a seperate MGF1 module. This patch primarily aims add removing the former.Being at it and as the OAEP code currently hard codes MGF1 (opposed to RFC 3447 which generally considers different MGFs) I changed the API in such a way, that the MGF can be injected.
For backwards compatibility the old call schemes are still supported and lead to on-the-fly creation of MGF1 module instances as needed.
Besides I've added further tests on PKCS#1 module to especially cover the exception branches as well as all possible (legacy) call/argument schemes.