Skip to content

Remove #!pwsh shebang from powershell code block#46

Open
Jawz84 wants to merge 5 commits into
dfinke:masterfrom
Jawz84:patch-1
Open

Remove #!pwsh shebang from powershell code block#46
Jawz84 wants to merge 5 commits into
dfinke:masterfrom
Jawz84:patch-1

Conversation

@Jawz84

@Jawz84 Jawz84 commented Nov 19, 2020

Copy link
Copy Markdown

.NET Interactive Notebooks add this shebang, it needs to be removed to get a nice, clean export.

.NET Interactive Notebooks add this shebang, it needs to be removed to get a nice, clean export.
@dfinke

dfinke commented Nov 19, 2020

Copy link
Copy Markdown
Owner

Thanks for the PR. Would you be up to adding a Pester test for that?

@Jawz84

Jawz84 commented Nov 20, 2020

Copy link
Copy Markdown
Author

I added two tests, and improved the implementation a bit. Let me know if you like it this way.

@Jawz84

Jawz84 commented Nov 20, 2020

Copy link
Copy Markdown
Author

Hmm. Tests pass in the development container, but auto CI seems to fail.
-edit: it was a CRLF vs LF issue, fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants