#1802 GUI State management implementation by laim2003 · Pull Request #1807 · devonfw/IDEasy

laim2003 · 2026-04-09T11:39:21Z

This PR fixes #1802

Implemented changes:

Implemented basic State Management for the IdeContext in the GUI
State management should be thread safe: Thread safe singleton implementation
Added custom adaption of JavaFXs alert class for IDEasy

Main points:

Basic state management
Start-context <-> context seperation
Ensure thread safety
Callback pattern for any dependent compontents

Checklist for this PR

Make sure everything is checked before merging this PR. For further info please also see
our DoD.

When running mvn clean test locally all tests pass and build is successful
PR title is of the form #«issue-id»: «brief summary» (e.g. #921: fixed setup.bat). If no issue ID exists, title only.
PR top-level comment summarizes what has been done and contains link to addressed issue(s)
PR and issue(s) have suitable labels
Issue is set to In Progress and assigned to you or there is no issue (might happen for very small PRs)
You followed all coding conventions
You have added the issue implemented by your PR in CHANGELOG.adoc unless issue is labeled
with internal

- Added testing class for modals

- Added logging to IdeGuiStateManager. - Added functionality, that selecting a different project now switches the IdeContext to the new project.

- Added testing class for modals

- Added logging to IdeGuiStateManager. - Added functionality, that selecting a different project now switches the IdeContext to the new project.

…t-for-gui' into devonfw#1785-implement-modals-in-idecontext

- Added functionality, that selecting a different project now switches the IdeContext to the new project.

…plementation' into devonfw#1802-state-management-implementation

…r other ui feature branches

- added DI for IdeGuiStateManager.switchContext

coveralls · 2026-04-09T15:30:03Z

Coverage Report for CI Build 25731784551

Coverage increased (+0.06%) to 70.686%

Details

Coverage increased (+0.06%) from the base build.
Patch coverage: No coverable lines changed in this PR.
31 coverage regressions across 3 files.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

31 previously-covered lines in 3 files lost coverage.

File	Lines Losing Coverage	Coverage
com/devonfw/ide/gui/MainController.java	17	64.0%
com/devonfw/ide/gui/App.java	13	0.0%
com/devonfw/ide/gui/AppLauncher.java	1	0.0%

Coverage Stats


Relevant Lines:	15567
Covered Lines:	11458
Line Coverage:	73.6%
Relevant Branches:	6934
Covered Branches:	4447
Branch Coverage:	64.13%
Branches in Coverage %:	Yes
Coverage Strength:	3.11 hits per line

💛 - Coveralls

…reading the list of workspaces/projects instead of reading those from the UI

…nager, when switchContext(Path rootDirectory, ...) is called.

This reverts commit 6f92d93.

…tateManager is now set when calling getInstance(), allowing us to provide a getInstance() method with a DI parameter

… getInstance()) (see previous commit)

…can be extended by tests

…plementation' into devonfw#1802-state-management-implementation

…eGuiStateManager;

…lure

…IdeGuiStateManager

- not automatically select a workspace - to seperate concerns of which functions update the workspace combobox and which the project combobox

…low new Select-Project-Then-Select-Workspace UI logic (previous commit)

…of own implementation

…plementation' into devonfw#1802-state-management-implementation

hohwille

@laim2003 thanks for your PR.
I like the general design and you added many valuable fixes and improvements for the GUI.
I still have some doubts about the singleton and static member access approach.
Typically this will sooner or later cause trouble.
Maybe we can avoid this where possible.

Please avoid this extensive copy&paste of pointless and confusing properties, plugin settings that are never used, etc.
The golden rule for ide-projects for test is to keep them as minimalistic as possible.
Every line from such file and every entire file that can be removed without the test failing should be removed.

hohwille · 2026-05-19T13:47:14Z

-
-          <!-- jar for test classes -->


why removing this comment that could be helpful to explain the execution?

hohwille · 2026-05-21T14:52:09Z

+import java.util.List;
+import java.util.stream.Stream;
+
+import org.jline.utils.Log;


This is IMHO the wrong logger

hohwille · 2026-05-21T14:56:23Z

+  private final ArrayList<String> projectNames = new ArrayList<>();
+  private final HashMap<String, ArrayList<String>> workspaces = new HashMap<>();


https://github.com/devonfw/IDEasy/blob/main/documentation/contributing/coding-conventions.adoc#prefer-general-api

Suggested change

private final ArrayList<String> projectNames = new ArrayList<>();

private final HashMap<String, ArrayList<String>> workspaces = new HashMap<>();

private final List<String> projectNames = new ArrayList<>();

private final Map<String, List<String>> workspaces = new HashMap<>();

You can even create custom Java classes to add more semantics since structures like Map<String, List<String> are hard to understand. If it was Map<String, Workspaces> it would be easier to understand esp. when Workspaces has reasonable JavaDoc.
However, I would question why we should store and cache the workspaces for all projects...
Your current code will never refresh the caches (surely you could be calling refreshProjects()) and therefore never shows updated information when a new workspace is created after the GUI was launched. When a project is changed, we should IMHO always refresh the newly selected project's workspaces and afford the 20ms to read them from the disc (again).

hohwille · 2026-05-22T15:54:12Z

+DOCKER_EDITION=docker
+FOO=foo-${BAR}
+TEST_ARGS1=${TEST_ARGS1} user1
+TEST_ARGS2=${TEST_ARGS2} user2
+TEST_ARGS3=${TEST_ARGS3} user3
+TEST_ARGS7=user7
+TEST_ARGS10=user10
+TEST_ARGSb=userb
+TEST_ARGSc=${TEST_ARGS1} userc
+TEST_ARGSd=${TEST_ARGS1} userd


the basic project was the first ide-project that we created.
It was misused later by many testers who were too lazy to create a new ide-project for their specific purpose.
Therefore all crazy things ended up in this basic project.
Please not not copy & paste all this mess into the gui module.
Nobody will ever understand why we have this here in gui and the true answer will be: "for nothing"...

hohwille · 2026-05-22T15:55:26Z

+DOCKER_EDITION=docker
+FOO=foo-${BAR}
+TEST_ARGS1=${TEST_ARGS1} user1
+TEST_ARGS2=${TEST_ARGS2} user2
+TEST_ARGS3=${TEST_ARGS3} user3
+TEST_ARGS7=user7
+TEST_ARGS10=user10
+TEST_ARGSb=userb
+TEST_ARGSc=${TEST_ARGS1} userc
+TEST_ARGSd=${TEST_ARGS1} userd


hohwille · 2026-05-22T15:55:44Z

+JAVA_VERSION=17*
+MVN_VERSION=3.9.0
+ECLIPSE_VERSION=2023-03
+INTELLIJ_EDITION=ultimate
+IDE_TOOLS=mvn,eclipse
+BAR=bar-${SOME}


hohwille · 2026-05-22T15:55:59Z

+DOCKER_EDITION=docker
+FOO=foo-${BAR}
+TEST_ARGS1=${TEST_ARGS1} user1
+TEST_ARGS2=${TEST_ARGS2} user2
+TEST_ARGS3=${TEST_ARGS3} user3
+TEST_ARGS7=user7
+TEST_ARGS10=user10
+TEST_ARGSb=userb
+TEST_ARGSc=${TEST_ARGS1} userc
+TEST_ARGSd=${TEST_ARGS1} userd


hohwille · 2026-05-22T15:56:12Z

+DOCKER_EDITION=docker
+FOO=foo-${BAR}
+TEST_ARGS1=${TEST_ARGS1} user1
+TEST_ARGS2=${TEST_ARGS2} user2
+TEST_ARGS3=${TEST_ARGS3} user3
+TEST_ARGS7=user7
+TEST_ARGS10=user10
+TEST_ARGSb=userb
+TEST_ARGSc=${TEST_ARGS1} userc
+TEST_ARGSd=${TEST_ARGS1} userd


laim2003 added 13 commits March 27, 2026 17:52

devonfw#1296: implemented basic IdeDialog Class

029f03d

devonfw#1296: Added basic context state manager class

89cfb67

- Added testing class for modals

devonfw#1785: Added basic question/confirmation modal implementation

a53296d

- Added logging to IdeGuiStateManager. - Added functionality, that selecting a different project now switches the IdeContext to the new project.

devonfw#1296: implemented basic IdeDialog Class

37cad74

devonfw#1296: Added basic context state manager class

55a50ce

- Added testing class for modals

devonfw#1785: Added basic question/confirmation modal implementation

3f1569f

- Added logging to IdeGuiStateManager. - Added functionality, that selecting a different project now switches the IdeContext to the new project.

Merge remote-tracking branch 'origin/devonfw#1296-implement-idecontex…

6ce99b3

…t-for-gui' into devonfw#1785-implement-modals-in-idecontext

devonfw#1785: - Added logging to IdeGuiStateManager.

7ef65f3

- Added functionality, that selecting a different project now switches the IdeContext to the new project.

devonfw#1724: implemented basic gui state management

1764b2f

devonfw#1802: implemented basic gui state management

ddd3e5f

Merge remote-tracking branch 'origin/devonfw#1802-state-management-im…

9c5a720

…plementation' into devonfw#1802-state-management-implementation

devonfw#1802: removed a few changes so this branch can be the base fo…

b28e216

…r other ui feature branches

devonfw#1802: disabled javadoc warning

234e98b

github-project-automation Bot added this to IDEasy board Apr 9, 2026

github-project-automation Bot moved this to 🆕 New in IDEasy board Apr 9, 2026

laim2003 self-assigned this Apr 9, 2026

laim2003 added GUI Graphical User Interface of IDEasy (aka dashboard) build with JavaFx bugfix PR that fixes a bug issue core FileAccess, ProcessUtil, IdeContext, etc. labels Apr 9, 2026

laim2003 moved this from 🆕 New to 🏗 In progress in IDEasy board Apr 9, 2026

devonfw#1802: - fixed AppBaseTest being stuck

1c4e766

- added DI for IdeGuiStateManager.switchContext

laim2003 added 2 commits April 14, 2026 14:37

Merge branch 'main' into devonfw#1802-state-management-implementation

6fc3884

devonfw#1802: Added ProjectManager class to handle business logic of …

2026757

…reading the list of workspaces/projects instead of reading those from the UI

laim2003 added the internal Nothing to be added to CHANGELOG, only internal story label Apr 14, 2026

laim2003 added 5 commits April 14, 2026 18:12

devonfw#1802: Updated IdeGuiStateManager to also update its projectMa…

c76e185

…nager, when switchContext(Path rootDirectory, ...) is called.

devonfw#1802: javafx updated to java 25

6f92d93

Merge branch 'main' into devonfw#1802-state-management-implementation

9f741a5

Revert "devonfw#1802: javafx updated to java 25"

48fe018

This reverts commit 6f92d93.

devonfw#1803: added DI for IDE_ROOT in GuiStateManager

e0ad015

laim2003 added 11 commits April 21, 2026 17:18

devonfw#1802: Workaround for IDE_ROOT=null issue. The ideRoot in GuiS…

40ff54e

…tateManager is now set when calling getInstance(), allowing us to provide a getInstance() method with a DI parameter

devonfw#1802: removed redundant DI variant of switchContext() (DI via…

0b67210

… getInstance()) (see previous commit)

devonfw#1802: Added tests for GuiStateManager

2e15d60

Merge branch 'main' into devonfw#1802-state-management-implementation

10cf940

devonfw#1802: Extracted mock IDE_ROOT logic into seperate class that …

5f0b40a

…can be extended by tests

Merge remote-tracking branch 'origin/devonfw#1802-state-management-im…

3b567ef

…plementation' into devonfw#1802-state-management-implementation

devonfw#1802: added ProjectManagerTest

e406b65

devonfw#1802: Detached startContext creation from switchContext in Id…

e0e2d9d

…eGuiStateManager;

devonfw#1802: Fixed bug in IdeGuiStateManagerTest leading to test fai…

d70f460

…lure

Merge branch 'main' into devonfw#1802-state-management-implementation

d6aace2

devonfw#1802: Added ContextChangeListener; improved thread safety of …

9c78eac

…IdeGuiStateManager

laim2003 moved this from 🏗 In progress to Team Review in IDEasy board Apr 24, 2026

laim2003 mentioned this pull request Apr 24, 2026

Add test-jar configuration in ide-cli #1850

Closed

Merge branch 'main' into devonfw#1802-state-management-implementation

4c84bb9

laim2003 moved this from Team Review to 🏗 In progress in IDEasy board Apr 28, 2026

laim2003 added 4 commits April 28, 2026 11:42

devonfw#1802: tests now use AbstractIdeContextTest

69055d9

devonfw#1802: Updated UI logic to:

9978ce9

- not automatically select a workspace - to seperate concerns of which functions update the workspace combobox and which the project combobox

devonfw#1802: cleaned up ProjectManagerTest, fixed AppBaseTest to fol…

ac3a045

…low new Select-Project-Then-Select-Workspace UI logic (previous commit)

devonfw#1802: cleaned up IdeGuiStateManagerTest

6c44432

laim2003 force-pushed the #1802-state-management-implementation branch from 459f762 to 6c44432 Compare April 28, 2026 17:28

Merge branch 'main' into devonfw#1802-state-management-implementation

c30c2ea

laim2003 moved this from 🏗 In progress to Team Review in IDEasy board Apr 28, 2026

laim2003 added 2 commits April 28, 2026 19:46

devonfw#1802: cleaned up ProjectManagerTest to use FileUtils instead …

1e8b556

…of own implementation

Merge remote-tracking branch 'origin/devonfw#1802-state-management-im…

d51111d

…plementation' into devonfw#1802-state-management-implementation

laim2003 marked this pull request as ready for review April 30, 2026 08:34

laim2003 moved this from Team Review to 👀 In review in IDEasy board May 2, 2026

laim2003 added 2 commits May 5, 2026 10:31

Merge branch 'main' into devonfw#1802-state-management-implementation

98a7072

Merge branch 'main' into devonfw#1802-state-management-implementation

c55a3a3

laim2003 mentioned this pull request May 12, 2026

#1784 implement java fx based progress bars for the GUI #1935

Draft

7 tasks

hohwille reviewed May 22, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#1802 GUI State management implementation#1807

#1802 GUI State management implementation#1807
laim2003 wants to merge 44 commits into
devonfw:mainfrom
laim2003:#1802-state-management-implementation

laim2003 commented Apr 9, 2026 •

edited

Loading

Uh oh!

coveralls commented Apr 9, 2026 •

edited

Loading

Uh oh!

hohwille left a comment

Uh oh!

hohwille May 19, 2026

Uh oh!

hohwille May 21, 2026

Uh oh!

hohwille May 21, 2026

Uh oh!

hohwille May 22, 2026 •

edited

Loading

Uh oh!

hohwille May 22, 2026

Uh oh!

hohwille May 22, 2026

Uh oh!

hohwille May 22, 2026

Uh oh!

hohwille May 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		private final ArrayList<String> projectNames = new ArrayList<>();
		private final HashMap<String, ArrayList<String>> workspaces = new HashMap<>();

Conversation

laim2003 commented Apr 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

This PR fixes #1802

Implemented changes:

Checklist for this PR

Uh oh!

coveralls commented Apr 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report for CI Build 25731784551

Coverage increased (+0.06%) to 70.686%

Details

Uncovered Changes

Coverage Regressions

Coverage Stats

💛 - Coveralls

Uh oh!

hohwille left a comment

Choose a reason for hiding this comment

Uh oh!

hohwille May 19, 2026

Choose a reason for hiding this comment

Uh oh!

hohwille May 21, 2026

Choose a reason for hiding this comment

Uh oh!

hohwille May 21, 2026

Choose a reason for hiding this comment

Uh oh!

hohwille May 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hohwille May 22, 2026

Choose a reason for hiding this comment

Uh oh!

hohwille May 22, 2026

Choose a reason for hiding this comment

Uh oh!

hohwille May 22, 2026

Choose a reason for hiding this comment

Uh oh!

hohwille May 22, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

laim2003 commented Apr 9, 2026 •

edited

Loading

coveralls commented Apr 9, 2026 •

edited

Loading

hohwille May 22, 2026 •

edited

Loading