mpi: Drop dual mode and tweak overlap2/full modes for GPU backends#2926
Open
JDBetteridge wants to merge 10 commits into
Open
mpi: Drop dual mode and tweak overlap2/full modes for GPU backends#2926JDBetteridge wants to merge 10 commits into
JDBetteridge wants to merge 10 commits into
Conversation
JDBetteridge
force-pushed
the
resurrect-mpi-dual-2
branch
from
ee16062 to
1bb7826
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2926 +/- ##
==========================================
- Coverage 83.35% 83.33% -0.02%
==========================================
Files 248 248
Lines 51734 51761 +27
Branches 4463 4462 -1
==========================================
+ Hits 43122 43135 +13
- Misses 7859 7875 +16
+ Partials 753 751 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
FabioLuporini
force-pushed
the
resurrect-mpi-dual-2
branch
from
1bb7826 to
fd4a133
Compare
FabioLuporini
changed the title
FabioLuporini
force-pushed
the
resurrect-mpi-dual-2
branch
from
fd4a133 to
9a56cdf
Compare
mloubout
reviewed
May 11, 2026
| else: | ||
| # A custom topology may contain integers or the wildcard '*' | ||
| self._topology = CustomTopology(topology, self._input_comm) | ||
| self._topology = CustomTopology( |
Contributor
There was a problem hiding this comment.
Might want to have compute_dims return a DimensionTuple as well
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needs CI running over it