compiler: catch corner case read after write#2909
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
mloubout
force-pushed
the
fix-break-clusters
branch
from
5b1f815 to
6e60d66
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2909 +/- ##
=======================================
Coverage 83.38% 83.39%
=======================================
Files 248 248
Lines 51685 51699 +14
Branches 4460 4460
=======================================
+ Hits 43100 43114 +14
+ Misses 7831 7830 -1
- Partials 754 755 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mloubout
force-pushed
the
fix-break-clusters
branch
6 times, most recently
from
9780878 to
a1f6a0a
Compare
|
|
||
| op = Operator(eqns) | ||
|
|
||
| assert_structure( |
There was a problem hiding this comment.
Maybe a brief comment explaining why fissioning in x is expected would be useful in the future?
| continue | ||
|
|
||
| distance = dependence.distance | ||
|
|
There was a problem hiding this comment.
leftover, or apply same style change to the other sibling methods
There was a problem hiding this comment.
This actually applies the same style as d_anti below that has the blank line but can remove blank line from both too if prefered
| assert all(trees[1].root.dim is tree.root.dim for tree in trees[1:]) | ||
|
|
||
|
|
||
| def test_scheduling_no_deriv(): |
There was a problem hiding this comment.
maybe mention "interpolation" in the name, or it may go underestimated
FabioLuporini
force-pushed
the
fix-break-clusters
branch
from
33a42c9 to
1c9c05a
Compare
FabioLuporini
force-pushed
the
fix-break-clusters
branch
from
1c9c05a to
d2cbc85
Compare
3 participants
tentative, trying to see what can do for these cases