Skip to content

feat: add Makefile targets for project-clone and project-backup images#1665

Draft
akurinnoy wants to merge 1 commit into
devfile:mainfrom
akurinnoy:feat/docker-targets-clone-backup
Draft

feat: add Makefile targets for project-clone and project-backup images#1665
akurinnoy wants to merge 1 commit into
devfile:mainfrom
akurinnoy:feat/docker-targets-clone-backup

Conversation

@akurinnoy

Copy link
Copy Markdown
Collaborator

Summary

  • Adds multi-arch build and push Makefile targets for project-clone and project-backup images, matching the existing controller image pattern
  • Previously these images required manual podman build/docker build commands that produced single-arch images only
  • All new targets support Docker (with buildx) and Podman, producing multi-arch (amd64 + arm64) images with proper manifest lists

New targets:

  • docker-project-clone — build and push project-clone
  • docker-project-backup — build and push project-backup
  • docker-all — build and push all three images (controller + project-clone + project-backup)

Updated docs: docs/release/README.md prerelease testing section now uses make docker-all

Test plan

  • make -n docker-all dry-run produces correct build/push commands for all 3 images
  • make help lists all new targets
  • Build and push with Docker: make docker-all DWO_IMG=... PROJECT_CLONE_IMG=... PROJECT_BACKUP_IMG=...
  • Build and push with Podman: DOCKER=podman make docker-all ...
  • Push confirmation prompt appears when targeting default quay.io/devfile/*:next images
  • Push confirmation is skipped with INITIATOR=CI

🤖 Generated with Claude Code

Add multi-arch build and push targets for project-clone and
project-backup images, matching the existing controller image pattern.
Previously these images required manual docker/podman build commands
that produced single-arch images only.

New targets:
- docker-project-clone: build and push project-clone
- docker-project-backup: build and push project-backup
- docker-all: build and push all three images

All targets support Docker (with buildx) and Podman, and produce
multi-arch (amd64 + arm64) images with proper manifest lists.

Assisted-by: Claude Code
Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
@openshift-ci

openshift-ci Bot commented Jun 25, 2026

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci

openshift-ci Bot commented Jun 25, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy
Once this PR has been reviewed and has the lgtm label, please assign dkwon17 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Jun 25, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 1d220803-cc44-4f39-9ba7-350317b76c0d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@tolusha

tolusha commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Hi! I'm che-ai-assistant — I help with your pull requests.

Available commands:

  • /che-ai-assistant generate-che-doc — Generate a documentation PR based on this PR's changes
  • /che-ai-assistant ok-pr-review — Run a comprehensive PR review (summary, code review, deep review, impact analysis)
  • /che-ai-assistant help — Show this help message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants