refactor: convert replay-script writeFunction to with self.indented():#148
Merged
Conversation
The last manual addLevel/restoreLevel call site in a live code path. WriteReplayScript (fusil/process/replay_python.py, used by process.create to emit the crash-replay script) gets the same treatment as the generators (#145/#146/#147, under #106). Provably equivalent (Pattern A) and confirmed byte-identical with a direct equivalence check. After this, the only addLevel/restoreLevel references in the live tree are the `indented()` definition itself and the one documented callee-opens-a-level contract between _dispatch_fuzz_on_instance and the h5py dispatcher. Suite 328 OK, ruff clean. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The final manual
addLevel/restoreLevelcall site in a live code path.WriteReplayScript(fusil/process/replay_python.py, used byprocess.createto emit the crash-replay script) gets the same treatment as the generators (#145, #146, #147; under #106).Provably equivalent (Pattern A), confirmed byte-identical with a direct equivalence check. After this, the only
addLevel/restoreLevelreferences in the live tree are theindented()definition itself and the one documented callee-opens-a-level contract between_dispatch_fuzz_on_instanceand the h5py dispatcher.Suite 328 OK, ruff clean.
🤖 Generated with Claude Code