Skip to content

chore(sdk): remove orphaned, never-compiled files#438

Open
dsmfa10 wants to merge 1 commit into
mainfrom
chore/sdk-remove-orphan-files
Open

chore(sdk): remove orphaned, never-compiled files#438
dsmfa10 wants to merge 1 commit into
mainfrom
chore/sdk-remove-orphan-files

Conversation

@dsmfa10
Copy link
Copy Markdown
Collaborator

@dsmfa10 dsmfa10 commented Jun 3, 2026

Problem

Two files are not declared by any mod, so they were never compiled:

  1. src/tests/schema_hash_tests.rs

    • src/tests/mod.rs declares only mod v3_object_authoring_tests;; this file
      is never mounted.
    • It also mixes bare Hash32 (from an include!) with a generated::Hash32
      path, so it would not compile if wired in.
  2. src/storage/dlv.rs

    • src/storage/mod.rs declares only bilateral, client_db, codecs, policy_fs, soft_vault — there is no mod dlv;. Its object_address helper is dead;
      the storage node has its own compute_object_address.

Fix

git rm both files. Nothing references them.

Verification

cargo check -p dsm_sdk unchanged.

CI gates & coverage

Full verification for this PR runs in CI — Rust (cargo fmt --check,
clippy -D warnings, workspace tests), Frontend, Android Unit Tests,
Coverage, SPDX headers, CodeQL (see the PR's Checks tab). The local
check noted above is a subset; the broader mandated gates (full workspace test
suite, codegen/scan, Android, Frontend) run in CI, not locally — none is
silently skipped.

Neither file is declared by any `mod`, so both were never compiled:
- `tests/schema_hash_tests.rs` — `tests/mod.rs` declares only
  `v3_object_authoring_tests`; this file is never mounted (and mixes
  bare `Hash32` with `generated::Hash32`, so it would not compile).
- `storage/dlv.rs` — `storage/mod.rs` declares only bilateral, client_db,
  codecs, policy_fs, soft_vault; `object_address` here is dead and the
  storage node has its own `compute_object_address`.

`cargo check -p dsm_sdk` is unchanged.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@codecov-commenter
Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants