chore(sdk): remove orphaned, never-compiled files#438
Open
dsmfa10 wants to merge 1 commit into
Open
Conversation
Neither file is declared by any `mod`, so both were never compiled: - `tests/schema_hash_tests.rs` — `tests/mod.rs` declares only `v3_object_authoring_tests`; this file is never mounted (and mixes bare `Hash32` with `generated::Hash32`, so it would not compile). - `storage/dlv.rs` — `storage/mod.rs` declares only bilateral, client_db, codecs, policy_fs, soft_vault; `object_address` here is dead and the storage node has its own `compute_object_address`. `cargo check -p dsm_sdk` is unchanged. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Two files are not declared by any
mod, so they were never compiled:src/tests/schema_hash_tests.rssrc/tests/mod.rsdeclares onlymod v3_object_authoring_tests;; this fileis never mounted.
Hash32(from aninclude!) with agenerated::Hash32path, so it would not compile if wired in.
src/storage/dlv.rssrc/storage/mod.rsdeclares onlybilateral, client_db, codecs, policy_fs, soft_vault— there is nomod dlv;. Itsobject_addresshelper is dead;the storage node has its own
compute_object_address.Fix
git rmboth files. Nothing references them.Verification
cargo check -p dsm_sdkunchanged.CI gates & coverage
Full verification for this PR runs in CI — Rust (
cargo fmt --check,clippy -D warnings, workspace tests), Frontend, Android Unit Tests,Coverage, SPDX headers, CodeQL (see the PR's Checks tab). The local
check noted above is a subset; the broader mandated gates (full workspace test
suite, codegen/scan, Android, Frontend) run in CI, not locally — none is
silently skipped.