feat: exclude TTL deployments from route create deployment dropdown#81
Merged
Conversation
Deployments with a TTL set are temporary and should not be used as route targets. Filter them out (ttl !== 0) from the dropdown on the route create page. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Deploying deploys-app--console with
|
| Latest commit: |
8f399ac
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://680ffb3a.deploys-app--console.pages.dev |
| Branch Preview URL: | https://claude-competent-raman-eb9bd.deploys-app--console.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ttl !== 0) from the deployment dropdown on the route create pagettl === -1, pending deletion), so they should not be valid route targetsReviewer notes
The filter
x.ttl === 0aligns with the existing convention used throughout the codebase:ttl === 0= permanent,ttl > 0= has TTL,ttl === -1= expired/pending deletion.