feat: show expired-pending-deletion state for TTL=-1 deployments#80
Merged
Conversation
The API now returns ttl=-1 for deployments that have expired but are waiting for GC cleanup. Surface this in the list and detail views with a danger-colored clock icon and "Expired — pending deletion" label. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Deploying deploys-app--console with
|
| Latest commit: |
7112e01
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://b87e407b.deploys-app--console.pages.dev |
| Branch Preview URL: | https://claude-gracious-hugle-c6f530.deploys-app--console.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ttl=-1when a deployment has expired but GC hasn't cleaned it up yet.ttl > 0(active TTL) andttl <= 0(no TTL), so-1was silently treated as "no TTL" and nothing was shown.ttl === -1in both the deployment list view and the detail view, showing a danger-colored clock icon with an "Expired — pending deletion" label.Changes
src/routes/(auth)/(project)/deployment/+page.svelte— list row: red clock icon with tooltip "Expired — pending deletion"src/routes/(auth)/(project)/deployment/(detail)/detail/+page.svelte— detail table row: red clock icon + inline textReviewer notes
No logic change to the deploy form — it already guards TTL pre-fill with
ttl > 0, so-1is correctly ignored there.