reference: fix the orphaned assert/strict node nav link#3327
Merged
Conversation
The node sidebar lists modules from node-rewrite-map.json, but node:assert/strict only re-exports node:assert and produces no symbols of its own, so deno doc generates no page for it (0 entries in node.json). The sidebar still linked to /api/node/assert/strict/ though - a 404 on every node reference page. Removing it from the rewrite map drops the broken link with no effect on generated output (it produced nothing). assert/strict users find the same symbols under node:assert, which is unchanged. This is the node counterpart of the Temporal fix (#3323); assert/strict is the only such orphan in the node module list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The node counterpart of the Temporal fix (#3323), and the last known
broken link from the reference rearchitecture.
The node reference sidebar lists modules from
node-rewrite-map.json.node:assert/strictis in that list, but it only re-exportsnode:assertin strict mode and declares no symbols of its own, so
deno docgeneratesno page for it (zero entries in the generated
node.json). The sidebarstill linked to
/api/node/assert/strict/- a 404 on every nodereference page.
Removing it from the rewrite map drops the broken link with no effect on
generated output, since it produced nothing. Users find the same symbols
under
node:assert, which is unchanged.Audited:
assert/strictis the only orphan among the 55 node modules.Verified: reference build green (105 pages), no page links to
/api/node/assert/strict/anymore, and theassertmodule page and itssidebar entry are unchanged.