Skip to content

test(e2e): add precheck for affinity and toleration e2e#2418

Open
LopatinDmitr wants to merge 1 commit into
mainfrom
test/e2e/affinity-toleration
Open

test(e2e): add precheck for affinity and toleration e2e#2418
LopatinDmitr wants to merge 1 commit into
mainfrom
test/e2e/affinity-toleration

Conversation

@LopatinDmitr
Copy link
Copy Markdown
Contributor

@LopatinDmitr LopatinDmitr commented May 29, 2026

Description

Add a dedicated e2e precheck for VirtualMachineAffinityAndToleration.

The test now declares its infrastructure dependency explicitly instead of using precheck.NoPrecheck.
The new precheck validates that the cluster has enough ready KVM-enabled nodes for the placement and migration scenarios covered by the test.

Why do we need it, and what problem does it solve?

VirtualMachineAffinityAndToleration depends on cluster topology:

  • at least 2 ready KVM-enabled nodes;
  • at least 1 ready KVM-enabled master node;
  • at least 2 ready KVM-enabled worker nodes.

Before this change, the test used NoPrecheck, so these requirements were implicit and failures happened later during test execution.
With the new precheck, an unsuitable cluster is rejected during the precheck phase with a clear error message.

What is the expected result?

  1. Run e2e with FOCUS=VirtualMachineAffinityAndToleration.
  2. On a suitable cluster, the suite passes the precheck phase and proceeds to the test.
  3. On an unsuitable cluster, the suite fails fast in SynchronizedBeforeSuite with a descriptive precheck error.

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Changelog entries

section: test
type: chore
summary: Add a dedicated precheck for the VirtualMachineAffinityAndToleration e2e test.
impact_level: low

@LopatinDmitr LopatinDmitr requested a review from Isteb4k as a code owner May 29, 2026 20:27
@LopatinDmitr LopatinDmitr added this to the v1.9.0 milestone May 29, 2026
Signed-off-by: Dmitry Lopatin <dmitry.lopatin@flant.com>
@LopatinDmitr LopatinDmitr force-pushed the test/e2e/affinity-toleration branch from a0bac9a to db470ef Compare May 29, 2026 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant