Skip to content

Error message with recursive error count#1334

Open
jorgengranseth wants to merge 4 commits into
datacontract:mainfrom
kartverket:error-message-with-recursive-error-count
Open

Error message with recursive error count#1334
jorgengranseth wants to merge 4 commits into
datacontract:mainfrom
kartverket:error-message-with-recursive-error-count

Conversation

@jorgengranseth

@jorgengranseth jorgengranseth commented Jun 23, 2026

Copy link
Copy Markdown
Contributor
  • Tests pass (uv run pytest)
  • Code formatted (uv run ruff check --fix && uv run ruff format)
  • README.md updated (if relevant)
  • CHANGELOG.md entry added we can add a changelog entry if this is considered sufficiently important

This is a completion of the suggestion outlined in #1331 under "Further Clarifications":

Show the first failed field and a count of the number of additional errors

as well as a test case to illustrate and verify correct behaviour.

A curious observation when writing this test is that Ibis uses the physical types from the data contract as the source of truth for the parquet schema, rather than parsing the parquet file. Importing a parquet file also yields only top-level typing for nested types (object and array). It seems like pyarrow.parquet is able to parse types correctly:

import pyarrow.parquet as pq

schema = pq.read_schema("tests/fixtures/parquet/data/nested_type_structures.parquet")
print(schema)
id: int64
values: list<element: int64>
  child 0, element: int64
metadata: struct<active: bool, name: string>
  child 0, active: bool
  child 1, name: string

So there may be room for improvement on the import side as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant