Error message with recursive error count#1334
Open
jorgengranseth wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
uv run pytest)uv run ruff check --fix && uv run ruff format)README.md updated (if relevant)CHANGELOG.md entry addedwe can add a changelog entry if this is considered sufficiently importantThis is a completion of the suggestion outlined in #1331 under "Further Clarifications":
as well as a test case to illustrate and verify correct behaviour.
A curious observation when writing this test is that Ibis uses the physical types from the data contract as the source of truth for the parquet schema, rather than parsing the parquet file. Importing a parquet file also yields only top-level typing for nested types (object and array). It seems like
pyarrow.parquetis able to parse types correctly:So there may be room for improvement on the import side as well.